Changeset 433d52f in mainline

Timestamp:

2018-12-10T11:15:10Z (6 years ago)

Author:

jxsvoboda <5887334+jxsvoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4f87a85a

Parents:

247fdea

git-author:

Jiri Svoboda <jiri@…> (2018-12-10 07:33:08)

git-committer:

jxsvoboda <5887334+jxsvoboda@…> (2018-12-10 11:15:10)

Message:

No need to compute number of used pages again

In as_area_change_flags we can just use used_space.pages which already
contains the number of used pages.

File:

• kernel/generic/src/mm/as.c (modified) (2 diffs)

kernel/generic/src/mm/as.c

@@ -1395 +1395 @@
         mutex_unlock(&area->sh_info->lock);
 
-        /*
-         * Compute total number of used pages
-         */
-        size_t used_pages = 0;
-
-        used_space_ival_t *ival = used_space_first(&area->used_space);
-        while (ival != NULL) {
-                used_pages += ival->count;
-                ival = used_space_next(ival);
-        }
-
         /* An array for storing frame numbers */
-        uintptr_t *old_frame = malloc(used_pages * sizeof(uintptr_t));
+        uintptr_t *old_frame = malloc(area->used_space.pages *
+            sizeof(uintptr_t));
         if (!old_frame) {
                 mutex_unlock(&area->lock);
@@ -1428 +1418 @@
         size_t frame_idx = 0;
 
-        ival = used_space_first(&area->used_space);
+        used_space_ival_t *ival = used_space_first(&area->used_space);
         while (ival != NULL) {
                 uintptr_t ptr = ival->page;