Changeset 44d8853 in mainline for uspace/drv/uhci/callback.c

Timestamp:

2011-01-28T23:51:36Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4046c1ea, c8ca07e

Parents:

e68de30

Message:

Fixed: Do not crash on zero buffers

File:

• uspace/drv/uhci/callback.c (modified) (1 diff)

uspace/drv/uhci/callback.c

@@ -9 +9 @@
         assert(instance);
         assert(func_in == NULL || func_out == NULL);
-        instance->new_buffer = malloc32(size);
-        if (!instance->new_buffer) {
-                uhci_print_error("Failed to allocate device acessible buffer.\n");
-                return ENOMEM;
+        if (size > 0) {
+                instance->new_buffer = malloc32(size);
+                if (!instance->new_buffer) {
+                        uhci_print_error("Failed to allocate device acessible buffer.\n");
+                        return ENOMEM;
+                }
+                if (func_out)
+                        memcpy(instance->new_buffer, buffer, size);
+        } else {
+                instance->new_buffer = NULL;
         }
 
-        if (func_out)
-                memcpy(instance->new_buffer, buffer, size);
 
         instance->callback_out = func_out;