Changes in / [151293d:49ce810] in mainline

Location:

uspace

Files:

• app/mkbd/main.c (modified) (2 diffs)
• drv/ohci/hc.c (modified) (1 diff)
• drv/uhci-hcd/uhci.c (modified) (4 diffs)
• drv/usbhid/mouse/mousedev.c (modified) (1 diff)
• lib/drv/include/remote_pci.h (modified) (1 diff)
• lib/drv/include/remote_usb.h (modified) (1 diff)
• lib/drv/include/remote_usbhc.h (modified) (1 diff)

uspace/app/mkbd/main.c

@@ -212 +212 @@
         }
         
-        char *devpath = argv[1];
-        //const char *devpath = "/hw/pci0/00:06.0/ohci-rh/usb00_a2/HID1/hid";
+        //char *devpath = argv[1];
+        const char *devpath = "/hw/pci0/00:06.0/ohci-rh/usb00_a2/HID1/hid";
         
         int rc;
@@ -297 +297 @@
                 }
                 
-                async_usleep(10000);
+                async_usleep(100000);
         }
         

uspace/drv/ohci/hc.c

@@ -343 +343 @@
 {
         assert(instance);
+        usb_log_debug("OHCI(%p) interrupt: %x.\n", instance, status);
         if ((status & ~I_SF) == 0) /* ignore sof status */
                 return;
-        usb_log_debug2("OHCI(%p) interrupt: %x.\n", instance, status);
         if (status & I_RHSC)
                 rh_interrupt(&instance->rh);

uspace/drv/uhci-hcd/uhci.c

@@ -61 +61 @@
 } uhci_t;
 
-static inline uhci_t * dev_to_uhci(const ddf_dev_t *dev)
+static inline uhci_t * dev_to_uhci(ddf_dev_t *dev)
 {
         assert(dev);
@@ -77 +77 @@
 {
         assert(dev);
-        uhci_t *uhci = dev_to_uhci(dev);
+        uhci_t *uhci = dev->driver_data;
+        assert(uhci);
         hc_t *hc = &uhci->hc;
-        const uint16_t status = IPC_GET_ARG1(*call);
+        uint16_t status = IPC_GET_ARG1(*call);
         assert(hc);
         hc_interrupt(hc, status);
 }
-/*----------------------------------------------------------------------------*/
-/** Operations supported by the HC driver */
-static ddf_dev_ops_t hc_ops = {
-        .interfaces[USBHC_DEV_IFACE] = &hc_iface, /* see iface.h/c */
-};
 /*----------------------------------------------------------------------------*/
 /** Get address of the device identified by handle.
@@ -119 +115 @@
  * @return Error code.
  */
-static int usb_iface_get_hc_handle(ddf_fun_t *fun, devman_handle_t *handle)
+static int usb_iface_get_hc_handle(
+    ddf_fun_t *fun, devman_handle_t *handle)
 {
         assert(fun);
@@ -134 +131 @@
         .get_hc_handle = usb_iface_get_hc_handle,
         .get_address = usb_iface_get_address
+};
+/*----------------------------------------------------------------------------*/
+/** Operations supported by the HC driver */
+static ddf_dev_ops_t hc_ops = {
+        .interfaces[USBHC_DEV_IFACE] = &hc_iface, /* see iface.h/c */
 };
 /*----------------------------------------------------------------------------*/

uspace/drv/usbhid/mouse/mousedev.c

@@ -234 +234 @@
         
         if (mouse_dev->mouse_phone < 0) {
-                usb_log_warning(NAME " No console phone.\n");
-                return true;
+                usb_log_error(NAME " No console phone.\n");
+                return false;   // ??
         }
 

uspace/lib/drv/include/remote_pci.h

@@ -36 +36 @@
 #define LIBDRV_REMOTE_PCI_H_
 
-extern remote_iface_t remote_pci_iface;
+remote_iface_t remote_pci_iface;
 
 #endif

uspace/lib/drv/include/remote_usb.h

@@ -36 +36 @@
 #define LIBDRV_REMOTE_USB_H_
 
-extern remote_iface_t remote_usb_iface;
+remote_iface_t remote_usb_iface;
 
 #endif

uspace/lib/drv/include/remote_usbhc.h

@@ -36 +36 @@
 #define LIBDRV_REMOTE_USBHC_H_
 
-extern remote_iface_t remote_usbhc_iface;
+remote_iface_t remote_usbhc_iface;
 
 #endif