Changeset 4a00bc9 in mainline for uspace/drv/bus/usb/xhci/transfers.c

Timestamp:

2018-01-10T13:29:52Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

398a94c

Parents:

f92f6b1

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-10 13:28:21)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-10 13:29:52)

Message:

xhci: fix errors reported by clang

Asserts were unnecessary, because the transfer type is an enum.
DMAMEM_4GiB is an uintptr_t constant.
There shall be at least one ring segment, and clang cannot infer that.
TRBs shall be 16-byte aligned to take aligned pointers from it.

File:

• uspace/drv/bus/usb/xhci/transfers.c (modified) (1 diff)

uspace/drv/bus/usb/xhci/transfers.c

@@ -341 +341 @@
 
         const usb_transfer_type_t type = batch->ep->transfer_type;
-        assert(type >= 0 && type < ARRAY_SIZE(transfer_handlers));
         assert(transfer_handlers[type]);