Changeset 4c6fd56 in mainline for uspace/lib/hound/src/protocol.c

Timestamp:

2023-09-16T19:58:18Z (16 months ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7d7f5e3

Parents:

6a0b2cc

git-author:

Jiri Svoboda <jiri@…> (2023-09-16 19:48:07)

git-committer:

Jiri Svoboda <jiri@…> (2023-09-16 19:58:18)

Message:

loc_server_register() should be callable more than once (API only)

Now loc_server_register() returns a pointer to a loc_srv_t object,
that is then passed to loc_service_register() and
loc_service_add_to_cat().

Added loc_server_unregister() that unregisters the server
and frees the loc_srv_t object.

Updated all callers. The implementation, however, is a stub.
It is not actually possible to call loc_server_register() more
than once, yet.

File:

• uspace/lib/hound/src/protocol.c (modified) (4 diffs)

uspace/lib/hound/src/protocol.c

@@ -1 +1 @@
 /*
+ * Copyright (c) 2023 Jiri Svoboda
  * Copyright (c) 2012 Jan Vesely
  * All rights reserved.
@@ -84 +85 @@
 const char *HOUND_SERVICE = "audio/hound";
 
+/** Server object */
+static loc_srv_t *hound_srv;
+
 /**
  * Start a new audio session.
@@ -730 +734 @@
 errno_t hound_server_register(const char *name, service_id_t *id)
 {
+        errno_t rc;
+
         if (!name || !id)
                 return EINVAL;
 
-        errno_t ret = loc_server_register(name);
-        if (ret != EOK)
-                return ret;
-
-        return loc_service_register(HOUND_SERVICE, id);
+        if (hound_srv != NULL)
+                return EBUSY;
+
+        rc = loc_server_register(name, &hound_srv);
+        if (rc != EOK)
+                return rc;
+
+        rc = loc_service_register(hound_srv, HOUND_SERVICE, id);
+        if (rc != EOK) {
+                loc_server_unregister(hound_srv);
+                return rc;
+        }
+
+        return EOK;
 }
 
@@ -746 +761 @@
 void hound_server_unregister(service_id_t id)
 {
-        loc_service_unregister(id);
+        loc_service_unregister(hound_srv, id);
+        loc_server_unregister(hound_srv);
 }