Changeset 4c6fd56 in mainline for uspace/srv/hid/remcons/remcons.c

Timestamp:

2023-09-16T19:58:18Z (16 months ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7d7f5e3

Parents:

6a0b2cc

git-author:

Jiri Svoboda <jiri@…> (2023-09-16 19:48:07)

git-committer:

Jiri Svoboda <jiri@…> (2023-09-16 19:58:18)

Message:

loc_server_register() should be callable more than once (API only)

Now loc_server_register() returns a pointer to a loc_srv_t object,
that is then passed to loc_service_register() and
loc_service_add_to_cat().

Added loc_server_unregister() that unregisters the server
and frees the loc_srv_t object.

Updated all callers. The implementation, however, is a stub.
It is not actually possible to call loc_server_register() more
than once, yet.

File:

• uspace/srv/hid/remcons/remcons.c (modified) (5 diffs)

uspace/srv/hid/remcons/remcons.c

@@ -1 +1 @@
 /*
+ * Copyright (c) 2023 Jiri Svoboda
  * Copyright (c) 2012 Vojtech Horky
  * All rights reserved.
@@ -110 +111 @@
 };
 
+static loc_srv_t *remcons_srv;
+
 static telnet_user_t *srv_to_user(con_srv_t *srv)
 {
@@ -301 +304 @@
         telnet_user_add(user);
 
-        errno_t rc = loc_service_register(user->service_name, &user->service_id);
+        errno_t rc = loc_service_register(remcons_srv, user->service_name,
+            &user->service_id);
         if (rc != EOK) {
                 telnet_user_error(user, "Unable to register %s with loc: %s.",
@@ -332 +336 @@
         fibril_mutex_unlock(&user->guard);
 
-        rc = loc_service_unregister(user->service_id);
+        rc = loc_service_unregister(remcons_srv, user->service_id);
         if (rc != EOK) {
                 telnet_user_error(user,
@@ -351 +355 @@
 
         async_set_fallback_port_handler(client_connection, NULL);
-        rc = loc_server_register(NAME);
+        rc = loc_server_register(NAME, &remcons_srv);
         if (rc != EOK) {
                 fprintf(stderr, "%s: Unable to register server\n", NAME);