Changeset 4c6fd56 in mainline for uspace/srv/hw/char/s3c24xx_uart/s3c24xx_uart.c

Timestamp:

2023-09-16T19:58:18Z (16 months ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7d7f5e3

Parents:

6a0b2cc

git-author:

Jiri Svoboda <jiri@…> (2023-09-16 19:48:07)

git-committer:

Jiri Svoboda <jiri@…> (2023-09-16 19:58:18)

Message:

loc_server_register() should be callable more than once (API only)

Now loc_server_register() returns a pointer to a loc_srv_t object,
that is then passed to loc_service_register() and
loc_service_add_to_cat().

Added loc_server_unregister() that unregisters the server
and frees the loc_srv_t object.

Updated all callers. The implementation, however, is a stub.
It is not actually possible to call loc_server_register() more
than once, yet.

File:

• uspace/srv/hw/char/s3c24xx_uart/s3c24xx_uart.c (modified) (3 diffs)

uspace/srv/hw/char/s3c24xx_uart/s3c24xx_uart.c

@@ -1 +1 @@
 /*
- * Copyright (c) 2010 Jiri Svoboda
+ * Copyright (c) 2023 Jiri Svoboda
  * All rights reserved.
  *
@@ -80 +80 @@
 int main(int argc, char *argv[])
 {
+        loc_srv_t *srv;
+
         printf("%s: S3C24xx on-chip UART driver\n", NAME);
 
         async_set_fallback_port_handler(s3c24xx_uart_connection, uart);
-        errno_t rc = loc_server_register(NAME);
+        errno_t rc = loc_server_register(NAME, &srv);
         if (rc != EOK) {
                 printf("%s: Unable to register server.\n", NAME);
@@ -90 +92 @@
 
         uart = malloc(sizeof(s3c24xx_uart_t));
-        if (uart == NULL)
-                return -1;
-
-        if (s3c24xx_uart_init(uart) != EOK)
-                return -1;
-
-        rc = loc_service_register(NAMESPACE "/" NAME, &uart->service_id);
+        if (uart == NULL) {
+                loc_server_unregister(srv);
+                return -1;
+        }
+
+        if (s3c24xx_uart_init(uart) != EOK) {
+                free(uart);
+                loc_server_unregister(srv);
+                return -1;
+        }
+
+        rc = loc_service_register(srv, NAMESPACE "/" NAME, &uart->service_id);
         if (rc != EOK) {
+                // XXX s3c24xx_uart_fini(uart);
+                free(uart);
+                loc_server_unregister(srv);
                 printf(NAME ": Unable to register device %s.\n",
                     NAMESPACE "/" NAME);