Changes in uspace/srv/fs/mfs/mfs_ops.c [1ba6651:4e00f87] in mainline

File:

• uspace/srv/fs/mfs/mfs_ops.c (modified) (18 diffs)

uspace/srv/fs/mfs/mfs_ops.c

@@ -88 +88 @@
 
 /* Hash table interface for open nodes hash table */
+
 typedef struct {
         service_id_t service_id;
@@ -189 +190 @@
                 /* This is a V1 or V2 Minix filesystem */
                 magic = sb->s_magic;
-        } else if (check_magic_number(sb3->s_magic, &native,
-            &version, &longnames)) {
+        } else if (check_magic_number(sb3->s_magic, &native, &version, &longnames)) {
                 /* This is a V3 Minix filesystem */
                 magic = sb3->s_magic;
@@ -345 +345 @@
         uint32_t inum;
 
+        mfsdebug("%s()\n", __FUNCTION__);
+
         r = mfs_instance_get(service_id, &inst);
         if (r != EOK)
@@ -377 +379 @@
                 ino_i->i_mode = S_IFDIR;
                 ino_i->i_nlinks = 1; /* This accounts for the '.' dentry */
-        } else {
+        } else
                 ino_i->i_mode = S_IFREG;
-                ino_i->i_nlinks = 0;
-        }
 
         ino_i->i_uid = 0;
@@ -419 +419 @@
         free(ino_i);
 out_err:
-        mfs_free_inode(inst, inum);
         return r;
 }
@@ -430 +429 @@
         struct mfs_dentry_info d_info;
         int r;
+
+        mfsdebug("%s()\n", __FUNCTION__);
 
         if (!S_ISDIR(ino_i->i_mode))
@@ -451 +452 @@
 
                 if (comp_size == dentry_name_size &&
-                    memcmp(component, d_info.d_name, dentry_name_size) == 0) {
+                    !bcmp(component, d_info.d_name, dentry_name_size)) {
                         /* Hit! */
                         mfs_node_core_get(rfn, mnode->instance,
@@ -477 +478 @@
         struct mfs_instance *instance;
 
+        mfsdebug("%s()\n", __FUNCTION__);
+
         rc = mfs_instance_get(service_id, &instance);
         if (rc != EOK)
@@ -489 +492 @@
         int rc = EOK;
         struct mfs_node *mnode = fsnode->data;
+
+        mfsdebug("%s()\n", __FUNCTION__);
 
         fibril_mutex_lock(&open_nodes_lock);
@@ -549 +554 @@
         int rc;
 
+        mfsdebug("%s()\n", __FUNCTION__);
+
         fibril_mutex_lock(&open_nodes_lock);
 
@@ -561 +568 @@
         if (already_open) {
                 mnode = hash_table_get_inst(already_open, struct mfs_node, link);
-
                 *rfn = mnode->fsnode;
                 mnode->refcnt++;
@@ -642 +648 @@
         struct mfs_sb_info *sbi = parent->instance->sbi;
         bool destroy_dentry = false;
+
+        mfsdebug("%s()\n", __FUNCTION__);
 
         if (str_size(name) > sbi->max_name_len)
@@ -665 +673 @@
                 r = mfs_insert_dentry(child, "..", parent->ino_i->index);
                 if (r != EOK) {
-                        mfs_remove_dentry(child, ".");
                         destroy_dentry = true;
                         goto exit;
@@ -694 +701 @@
         int r;
 
+        mfsdebug("%s()\n", __FUNCTION__);
+
         if (!parent)
                 return EBUSY;
@@ -764 +773 @@
 {
         int rc;
-        fs_node_t *fn = NULL;
+        fs_node_t *fn;
 
         rc = mfs_node_get(&fn, service_id, index);
@@ -915 +924 @@
                 
                 r = mfs_write_map(mnode, pos, block, &dummy);
-                if (r != EOK) {
-                        mfs_free_zone(mnode->instance, block);
+                if (r != EOK)
                         goto out_err;
-                }
 
                 flags = BLOCK_FLAGS_NOREAD;
@@ -958 +965 @@
 mfs_destroy(service_id_t service_id, fs_index_t index)
 {
-        fs_node_t *fn = NULL;
+        fs_node_t *fn;
         int r;
 
@@ -1101 +1108 @@
 mfs_sync(service_id_t service_id, fs_index_t index)
 {
-        fs_node_t *fn = NULL;
+        fs_node_t *fn;
         int rc = mfs_node_get(&fn, service_id, index);
         if (rc != EOK)