Changeset 4ff66ae in mainline for uspace/srv/taskman/main.c

Timestamp:

2019-08-07T11:18:35Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

87a31ef2

Parents:

bb57a00

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-11-13 03:13:03)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 11:18:35)

Message:

taskman: Bind events dump to register handler

• So that no events are processed twice or omitted.

File:

• uspace/srv/taskman/main.c (modified) (4 diffs)

uspace/srv/taskman/main.c

@@ -186 +186 @@
         DPRINTF("%s:%i from %llu\n", __func__, __LINE__, icall->in_task_id);
 
+        bool past_events = IPC_GET_ARG1(*icall);
+
         /* Atomic -- will be used for notifications only */
         async_sess_t *sess = async_callback_receive(EXCHANGE_ATOMIC);
@@ -193 +195 @@
         }
 
-        int rc = event_register_listener(icall->in_task_id, sess);
-        async_answer_0(iid, rc);
-}
-
-static void taskman_ctl_dump_events(ipc_callid_t iid, ipc_call_t *icall)
-{
-        DPRINTF("%s:%i from %llu\n", __func__, __LINE__, icall->in_task_id);
-
-        dump_events(icall->in_task_id, iid);
+        event_register_listener(icall->in_task_id, past_events, sess, iid);
 }
 
@@ -263 +257 @@
                 taskman_ctl_ev_callback(iid, icall);
                 break;
-        case TASKMAN_DUMP_EVENTS:
-                taskman_ctl_dump_events(iid, icall);
-                break;
         default:
                 return false;
@@ -274 +265 @@
 static bool handle_implicit_call(ipc_callid_t iid, ipc_call_t *icall)
 {
-        DPRINTF("%s:%i %i(%i) from %llu\n", __func__, __LINE__,
+        /*DPRINTF("%s:%i %i(%i) from %llu\n", __func__, __LINE__,
             IPC_GET_IMETHOD(*icall),
             IPC_GET_ARG1(*icall),
-            icall->in_task_id);
+            icall->in_task_id);*/
 
         if (IPC_GET_IMETHOD(*icall) < IPC_FIRST_USER_METHOD) {