Changes in kernel/arch/abs32le/src/debug/stacktrace.c [d99c1d2:50fda24] in mainline

File:

• kernel/arch/abs32le/src/debug/stacktrace.c (modified) (4 diffs)

kernel/arch/abs32le/src/debug/stacktrace.c

@@ -27 +27 @@
  */
 
-/** @addtogroup abs32le
+/** @addtogroup ia32
  * @{
  */
@@ -35 +35 @@
 #include <stacktrace.h>
 #include <syscall/copy.h>
+#include <arch/types.h>
 #include <typedefs.h>
+
+#define FRAME_OFFSET_FP_PREV    0
+#define FRAME_OFFSET_RA         1
 
 bool kernel_frame_pointer_validate(uintptr_t fp)
 {
-        return true;
+        return fp != 0;
 }
 
 bool kernel_frame_pointer_prev(uintptr_t fp, uintptr_t *prev)
 {
+        uint32_t *stack = (void *) fp;
+        *prev = stack[FRAME_OFFSET_FP_PREV];
         return true;
 }
@@ -49 +55 @@
 bool kernel_return_address_get(uintptr_t fp, uintptr_t *ra)
 {
+        uint32_t *stack = (void *) fp;
+        *ra = stack[FRAME_OFFSET_RA];
         return true;
 }
@@ -54 +62 @@
 bool uspace_frame_pointer_validate(uintptr_t fp)
 {
-        return true;
+        return fp != 0;
 }
 
 bool uspace_frame_pointer_prev(uintptr_t fp, uintptr_t *prev)
 {
-        return true;
+        return !copy_from_uspace((void *) prev,
+            (uint32_t *) fp + FRAME_OFFSET_FP_PREV, sizeof(*prev));
 }
 
 bool uspace_return_address_get(uintptr_t fp, uintptr_t *ra)
 {
-        return true;
-}
-
-uintptr_t frame_pointer_get(void)
-{
-        return 0;
-}
-
-uintptr_t program_counter_get(void)
-{
-        return 0;
+        return !copy_from_uspace((void *) ra, (uint32_t *) fp + FRAME_OFFSET_RA,
+            sizeof(*ra));
 }