Changeset 516e780 in mainline for uspace/lib/math/generic/fabs.c

Timestamp:

2018-08-31T11:55:41Z (6 years ago)

Author:

GitHub <noreply@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fa86fff

Parents:

7f7d642

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-08-31 11:55:41)

git-committer:

GitHub <noreply@…> (2018-08-31 11:55:41)

Message:

Strip down libmath. (#45)

libmath is mostly unused (except for trunc(), sin() and cos()), and most functions in it are either very imprecise or downright broken. Additionally, it is implemented in manner that conflicts with C standard. Instead of trying to fix all the shortcomings while maintaining unused functionality, I'm opting to simply remove most of it and only keep the parts that are currently necessary.

Later readdition of the removed functions is possible, but there needs to be a reliable way to evaluate their quality first.

File:

• uspace/lib/math/generic/fabs.c (modified) (2 diffs)

uspace/lib/math/generic/fabs.c

@@ -1 +1 @@
 /*
- * Copyright (c) 2015 Jiri Svoboda
+ * Copyright (c) 2014 Martin Decky
  * All rights reserved.
  *
@@ -34 +34 @@
 
 #include <math.h>
-#include <fabs.h>
 
-/** Absolute value (32-bit floating point)
- *
- * Compute absolute value.
- *
- * @param arg Argument.
- *
- * @return Absolute value.
- *
- */
-float32_t float32_fabs(float32_t arg)
+float fabsf(float val)
 {
-        if (arg < 0.0)
-                return -arg;
-        else
-                return arg;
+        return copysignf(val, 1.0f);
 }
 
-/** Absolute value (64-bit floating point)
- *
- * Compute absolute value.
- *
- * @param arg Argument.
- *
- * @return Absolute value.
- *
- */
-float64_t float64_fabs(float64_t arg)
+double fabs(double val)
 {
-        if (arg < 0.0)
-                return -arg;
-        else
-                return arg;
+        return copysign(val, 1.0);
 }