Changes in uspace/app/init/init.c [991f645:527298a] in mainline

File:

• uspace/app/init/init.c (modified) (8 diffs)

uspace/app/init/init.c

@@ -124 +124 @@
 static void spawn(const char *fname)
 {
-        int rc;
+        const char *argv[2];
         struct stat s;
         
@@ -131 +131 @@
         
         printf("%s: Spawning %s\n", NAME, fname);
-        rc = task_spawnl(NULL, fname, fname, NULL);
-        if (rc != EOK) {
+        
+        argv[0] = fname;
+        argv[1] = NULL;
+        
+        int err;
+        if (!task_spawn(fname, argv, &err))
                 printf("%s: Error spawning %s (%s)\n", NAME, fname,
-                    str_error(rc));
-        }
+                    str_error(err));
 }
 
 static void srv_start(const char *fname)
 {
+        const char *argv[2];
         task_id_t id;
         task_exit_t texit;
@@ -149 +153 @@
         
         printf("%s: Starting %s\n", NAME, fname);
-        rc = task_spawnl(&id, fname, fname, NULL);
+        
+        argv[0] = fname;
+        argv[1] = NULL;
+        
+        id = task_spawn(fname, argv, &retval);
         if (!id) {
                 printf("%s: Error spawning %s (%s)\n", NAME, fname,
-                    str_error(rc));
+                    str_error(retval));
                 return;
         }
@@ -159 +167 @@
         if (rc != EOK) {
                 printf("%s: Error waiting for %s (%s(\n", NAME, fname,
-                    str_error(rc));
+                    str_error(retval));
                 return;
         }
         
-        if (texit != TASK_EXIT_NORMAL) {
-                printf("%s: Server %s failed to start (unexpectedly "
-                    "terminated)\n", NAME, fname);
-                return;
-        }
-
-        if (retval != 0) {
-                printf("%s: Server %s failed to start (exit code %d)\n", NAME,
-                        fname, retval);
+        if ((texit != TASK_EXIT_NORMAL) || (retval != 0)) {
+                printf("%s: Server %s failed to start (%s)\n", NAME,
+                        fname, str_error(retval));
         }
 }
@@ -177 +179 @@
 static void console(const char *dev)
 {
+        const char *argv[3];
         char hid_in[DEVMAP_NAME_MAXLEN];
         int rc;
@@ -185 +188 @@
         
         /* Wait for the input device to be ready */
-        devmap_handle_t handle;
+        dev_handle_t handle;
         rc = devmap_device_get_handle(dev, &handle, IPC_FLAG_BLOCKING);
-        if (rc != EOK) {
+        
+        if (rc == EOK) {
+                argv[0] = SRV_CONSOLE;
+                argv[1] = hid_in;
+                argv[2] = NULL;
+                
+                if (!task_spawn(SRV_CONSOLE, argv, &rc))
+                        printf("%s: Error spawning %s %s (%s)\n", NAME, SRV_CONSOLE,
+                            hid_in, str_error(rc));
+        } else
                 printf("%s: Error waiting on %s (%s)\n", NAME, hid_in,
                     str_error(rc));
-                return;
-        }
-        
-        rc = task_spawnl(NULL, SRV_CONSOLE, SRV_CONSOLE, hid_in, NULL);
-        if (rc != EOK) {
-                printf("%s: Error spawning %s %s (%s)\n", NAME, SRV_CONSOLE,
-                    hid_in, str_error(rc));
-        }
-}
-
-static void getterm(const char *dev, const char *app, bool wmsg)
-{
+}
+
+static void getterm(const char *dev, const char *app)
+{
+        const char *argv[4];
         char term[DEVMAP_NAME_MAXLEN];
         int rc;
@@ -210 +215 @@
         
         /* Wait for the terminal device to be ready */
-        devmap_handle_t handle;
+        dev_handle_t handle;
         rc = devmap_device_get_handle(dev, &handle, IPC_FLAG_BLOCKING);
-        if (rc != EOK) {
+        
+        if (rc == EOK) {
+                argv[0] = APP_GETTERM;
+                argv[1] = term;
+                argv[2] = app;
+                argv[3] = NULL;
+                
+                if (!task_spawn(APP_GETTERM, argv, &rc))
+                        printf("%s: Error spawning %s %s %s (%s)\n", NAME, APP_GETTERM,
+                            term, app, str_error(rc));
+        } else
                 printf("%s: Error waiting on %s (%s)\n", NAME, term,
                     str_error(rc));
-                return;
-        }
-        
-        if (wmsg) {
-                rc = task_spawnl(NULL, APP_GETTERM, APP_GETTERM, "-w", term,
-                    app, NULL);
-                if (rc != EOK) {
-                        printf("%s: Error spawning %s -w %s %s (%s)\n", NAME,
-                            APP_GETTERM, term, app, str_error(rc));
-                }
-        } else {
-                rc = task_spawnl(NULL, APP_GETTERM, APP_GETTERM, term, app,
-                    NULL);
-                if (rc != EOK) {
-                        printf("%s: Error spawning %s %s %s (%s)\n", NAME,
-                            APP_GETTERM, term, app, str_error(rc));
-                }
-        }
 }
 
@@ -305 +302 @@
 #endif
         
-        getterm("term/vc0", "/app/bdsh", true);
-        getterm("term/vc1", "/app/bdsh", false);
-        getterm("term/vc2", "/app/bdsh", false);
-        getterm("term/vc3", "/app/bdsh", false);
-        getterm("term/vc4", "/app/bdsh", false);
-        getterm("term/vc5", "/app/bdsh", false);
-        getterm("term/vc6", "/app/klog", false);
+        getterm("term/vc0", "/app/bdsh");
+        getterm("term/vc1", "/app/bdsh");
+        getterm("term/vc2", "/app/bdsh");
+        getterm("term/vc3", "/app/bdsh");
+        getterm("term/vc4", "/app/bdsh");
+        getterm("term/vc5", "/app/bdsh");
+        getterm("term/vc6", "/app/klog");
         
         return 0;