Changeset 5552d60 in mainline

Timestamp:

2006-05-28T20:01:55Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a6cb8cb

Parents:

d6e5cbc

Message:

Fight TLB inconsistency by proper placing of tlb_shootdown_start() and tlb_shootdown_finalize() in as.c.

File:

• generic/src/mm/as.c (modified) (4 diffs)

generic/src/mm/as.c

@@ -271 +271 @@
                  * No need to check for overlaps.
                  */
+
+                /*
+                 * Start TLB shootdown sequence.
+                 */
+                tlb_shootdown_start(TLB_INVL_PAGES, AS->asid, area->base + pages*PAGE_SIZE, area->pages - pages);
 
                 /*
@@ -331 +336 @@
                         }
                 }
-                /*
-                 * Invalidate TLB's.
-                 */
-                tlb_shootdown_start(TLB_INVL_PAGES, AS->asid, area->base + pages*PAGE_SIZE, area->pages - pages);
+
+                /*
+                 * Finish TLB shootdown sequence.
+                 */
                 tlb_invalidate_pages(AS->asid, area->base + pages*PAGE_SIZE, area->pages - pages);
                 tlb_shootdown_finalize();
@@ -384 +389 @@
 
         base = area->base;
+
+        /*
+         * Start TLB shootdown sequence.
+         */
+        tlb_shootdown_start(TLB_INVL_PAGES, AS->asid, area->base, area->pages);
 
         /*
@@ -418 +428 @@
                 }
         }
-        btree_destroy(&area->used_space);
-
-        /*
-         * Invalidate TLB's.
-         */
-        tlb_shootdown_start(TLB_INVL_PAGES, AS->asid, area->base, area->pages);
+
+        /*
+         * Finish TLB shootdown sequence.
+         */
         tlb_invalidate_pages(AS->asid, area->base, area->pages);
         tlb_shootdown_finalize();
+        
+        btree_destroy(&area->used_space);
 
         area->attributes |= AS_AREA_ATTR_PARTIAL;