Changeset 560b81c in mainline for kernel/arch/sparc64/src/mm/sun4u/tlb.c

Timestamp:

2016-09-17T15:09:40Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ae66564

Parents:

97b8ca9

Message:

Make sure to test the present bit of the found PTE

By design, page_mapping_find() can return true and a copy of a PTE
which is not present. It is therefore necessary to test the found PTE
by PTE_PRESENT() macro.

File:

• kernel/arch/sparc64/src/mm/sun4u/tlb.c (modified) (3 diffs)

kernel/arch/sparc64/src/mm/sun4u/tlb.c

@@ -201 +201 @@
         bool found = page_mapping_find(AS, istate->tpc, true, &t);
         if (found && PTE_EXECUTABLE(&t)) {
+                ASSERT(t.p);
+
                 /*
                  * The mapping was found in the software page hash table.
@@ -256 +258 @@
         bool found = page_mapping_find(as, page_16k, true, &t);
         if (found) {
+                ASSERT(t.p);
+
                 /*
                  * The mapping was found in the software page hash table.
@@ -297 +301 @@
         bool found = page_mapping_find(as, page_16k, true, &t);
         if (found && PTE_WRITABLE(&t)) {
+                ASSERT(t.p);
+
                 /*
                  * The mapping was found in the software page hash table and is