Changeset 561f41b in mainline for uspace/drv/ohci/main.c

Timestamp:

2011-05-07T16:00:10Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

60b3bea

Parents:

b23e9cc (diff), 3ae5ca8 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Major refactoring #211 should be fixed

UHCI: all interrupts are either communication driven or fatal
OHCI: control is taken only after we can handle interrupts

File:

• uspace/drv/ohci/main.c (modified) (2 diffs)

uspace/drv/ohci/main.c

@@ -43 +43 @@
 #define NAME "ohci"
 
-static int ohci_add_device(ddf_dev_t *device);
+/** Initializes a new ddf driver instance of OHCI hcd.
+ *
+ * @param[in] device DDF instance of the device to initialize.
+ * @return Error code.
+ */
+static int ohci_add_device(ddf_dev_t *device)
+{
+        usb_log_debug("ohci_add_device() called\n");
+        assert(device);
+
+        int ret = device_setup_ohci(device);
+        if (ret != EOK) {
+                usb_log_error("Failed to initialize OHCI driver: %s.\n",
+                    str_error(ret));
+                return ret;
+        }
+        usb_log_info("Controlling new OHCI device '%s'.\n", device->name);
+
+        return EOK;
+}
 /*----------------------------------------------------------------------------*/
 static driver_ops_t ohci_driver_ops = {
@@ -53 +72 @@
         .driver_ops = &ohci_driver_ops
 };
-/*----------------------------------------------------------------------------*/
-/** Initializes a new ddf driver instance of OHCI hcd.
- *
- * @param[in] device DDF instance of the device to initialize.
- * @return Error code.
- */
-int ohci_add_device(ddf_dev_t *device)
-{
-        usb_log_debug("ohci_add_device() called\n");
-        assert(device);
-        ohci_t *ohci = malloc(sizeof(ohci_t));
-        if (ohci == NULL) {
-                usb_log_error("Failed to allocate OHCI driver.\n");
-                return ENOMEM;
-        }
-
-        int ret = ohci_init(ohci, device);
-        if (ret != EOK) {
-                usb_log_error("Failed to initialize OHCI driver: %s.\n",
-                    str_error(ret));
-                return ret;
-        }
-//      device->driver_data = ohci;
-        hc_register_hub(&ohci->hc, ohci->rh_fun);
-
-        usb_log_info("Controlling new OHCI device `%s'.\n", device->name);
-
-        return EOK;
-}
 /*----------------------------------------------------------------------------*/
 /** Initializes global driver structures (NONE).