Changes in uspace/lib/posix/source/unistd.c [6afc9d7:5759642f] in mainline

File:

• uspace/lib/posix/source/unistd.c (modified) (16 diffs)

uspace/lib/posix/source/unistd.c

@@ -105 +105 @@
 char *posix_getcwd(char *buf, size_t size)
 {
-        char *p = getcwd(buf, size);
-
-        if (p == NULL) {
-                errno = -errno;
+        /* Native getcwd() does not set any errno despite the fact that general
+         * usage pattern of this function depends on it (caller is repeatedly
+         * guessing the required size of the buffer by checking for ERANGE on
+         * failure). */
+        if (size == 0) {
+                errno = EINVAL;
                 return NULL;
         }
-
-        return p;
+        
+        /* Save the original value to comply with the "no modification on
+         * success" semantics.
+         */
+        int orig_errno = errno;
+        errno = EOK;
+        
+        char *ret = getcwd(buf, size);
+        if (ret == NULL) {
+                /* Check errno to avoid shadowing other possible errors. */
+                if (errno == EOK) {
+                        errno = ERANGE;
+                }
+        } else {
+                /* Success, restore previous errno value. */
+                errno = orig_errno;
+        }
+        
+        return ret;
 }
 
@@ -122 +141 @@
 int posix_chdir(const char *path)
 {
-        return negerrno(chdir, path);
+        return errnify(chdir, path);
 }
 
@@ -175 +194 @@
 int posix_close(int fildes)
 {
-        return negerrno(close, fildes);
+        return errnify(close, fildes);
 }
 
@@ -188 +207 @@
 ssize_t posix_read(int fildes, void *buf, size_t nbyte)
 {
-        return negerrno(read, fildes, buf, nbyte);
+        return errnify(read, fildes, buf, nbyte);
 }
 
@@ -201 +220 @@
 ssize_t posix_write(int fildes, const void *buf, size_t nbyte)
 {
-        return negerrno(write, fildes, buf, nbyte);
-}
-
-/**
- * Reposition read/write file offset
- *
- * @param fildes File descriptor of the opened file.
- * @param offset New offset in the file.
- * @param whence The position from which the offset argument is specified.
- * @return Upon successful completion, returns the resulting offset
- *         as measured in bytes from the beginning of the file, -1 otherwise.
- */
-posix_off_t posix_lseek(int fildes, posix_off_t offset, int whence)
-{
-        return negerrno(lseek, fildes, offset, whence);
+        return errnify(write, fildes, buf, nbyte);
 }
 
@@ -226 +231 @@
 int posix_fsync(int fildes)
 {
-        return negerrno(fsync, fildes);
+        return errnify(fsync, fildes);
 }
 
@@ -238 +243 @@
 int posix_ftruncate(int fildes, posix_off_t length)
 {
-        return negerrno(ftruncate, fildes, (aoff64_t) length);
+        return errnify(ftruncate, fildes, (aoff64_t) length);
 }
 
@@ -249 +254 @@
 int posix_rmdir(const char *path)
 {
-        return negerrno(rmdir, path);
+        return errnify(rmdir, path);
 }
 
@@ -260 +265 @@
 int posix_unlink(const char *path)
 {
-        return negerrno(unlink, path);
+        return errnify(unlink, path);
 }
 
@@ -284 +289 @@
 int posix_dup2(int fildes, int fildes2)
 {
-        return negerrno(dup2, fildes, fildes2);
+        return errnify(dup2, fildes, fildes2);
 }
 
@@ -302 +307 @@
                  * Check file existence by attempting to open it.
                  */
-                int fd = negerrno(open, path, O_RDONLY);
+                int fd = open(path, O_RDONLY);
                 if (fd < 0) {
-                        /* errno was set by open() */
+                        errno = -fd;
                         return -1;
                 }
@@ -370 +375 @@
         // TODO: low priority, just a compile-time dependency of binutils
         not_implemented();
-        return -1;
 }
 
@@ -381 +385 @@
         // TODO: low priority, just a compile-time dependency of binutils
         not_implemented();
-        return -1;
 }
 
@@ -394 +397 @@
         // TODO: low priority, just a compile-time dependency of binutils
         not_implemented();
-        return -1;
 }
 
@@ -407 +409 @@
         // TODO: low priority, just a compile-time dependency of binutils
         not_implemented();
-        return -1;
 }
 
@@ -419 +420 @@
         // TODO: low priority, just a compile-time dependency of binutils
         not_implemented();
-        return -1;
 }