Changeset 58563585 in mainline for uspace/lib/usbdev/src/devpoll.c

Timestamp:

2016-08-31T11:15:39Z (8 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

10cb47e

Parents:

7a67416

Message:

code review and cstyle cleanup (no change in functionality)

File:

• uspace/lib/usbdev/src/devpoll.c (modified) (4 diffs)

uspace/lib/usbdev/src/devpoll.c

@@ -33 +33 @@
  * USB device driver framework - automatic interrupt polling.
  */
+
 #include <usb/dev/device.h>
 #include <usb/dev/pipes.h>
@@ -85 +86 @@
 
         if (params->debug > 0) {
-                const usb_endpoint_mapping_t *mapping
-                    = data->polling_mapping;
+                const usb_endpoint_mapping_t *mapping =
+                    data->polling_mapping;
                 usb_log_debug("Poll (%p): started polling of `%s' - " \
                     "interface %d (%s,%d,%d), %zuB/%zu.\n",
@@ -154 +155 @@
 
                 /* Take a rest before next request. */
-                //TODO: This is broken, the time is in ms not us.
+                
+                // FIXME TODO: This is broken, the time is in ms not us.
                 // but first we need to fix drivers to actually stop using this,
-                // since polling dealy should be implemented in HC schedule
+                // since polling delay should be implemented in HC schedule
                 async_usleep(params->delay);
         }
@@ -213 +215 @@
         if (request_size == 0)
                 return EINVAL;
-
+        
         if (!epm || (epm->pipe.transfer_type != USB_TRANSFER_INTERRUPT) ||
             (epm->pipe.direction != USB_DIRECTION_IN))
                 return EINVAL;
-
+        
 
         polling_data_t *polling_data = malloc(sizeof(polling_data_t));