Changes in uspace/drv/pciintel/pci.c [91579d5:5857be2] in mainline

File:

• uspace/drv/pciintel/pci.c (modified) (18 diffs)

uspace/drv/pciintel/pci.c

@@ -48 +48 @@
 
 #include <ddf/driver.h>
+#include <ddf/log.h>
 #include <devman.h>
 #include <ipc/devman.h>
@@ -95 +96 @@
         sysarg_t i8259;
 
-        int irc_phone = -1;
-        int irc_service = -1;
-
-        if ((sysinfo_get_value("apic", &apic) == EOK) && (apic)) {
-                irc_service = SERVICE_APIC;
-        } else if ((sysinfo_get_value("i8259", &i8259) == EOK) && (i8259)) {
-                irc_service = SERVICE_I8259;
-        }
-
-        if (irc_service == -1) {
-                return false;
-        }
-
-        irc_phone = service_connect_blocking(irc_service, 0, 0);
+        int irc_phone = ENOTSUP;
+
+        if (((sysinfo_get_value("apic", &apic) == EOK) && (apic))
+            || ((sysinfo_get_value("i8259", &i8259) == EOK) && (i8259))) {
+                irc_phone = service_connect_blocking(SERVICE_IRC, 0, 0);
+        }
+
         if (irc_phone < 0) {
                 return false;
         }
 
-        size_t i;
-        for (i = 0; i < dev_data->hw_resources.count; i++) {
-                if (dev_data->hw_resources.resources[i].type == INTERRUPT) {
-                        int irq = dev_data->hw_resources.resources[i].res.interrupt.irq;
-                        int rc = async_req_1_0(irc_phone, IRC_ENABLE_INTERRUPT, irq);
+        size_t i = 0;
+        hw_resource_list_t *res = &dev_data->hw_resources;
+        for (; i < res->count; i++) {
+                if (res->resources[i].type == INTERRUPT) {
+                        const int irq = res->resources[i].res.interrupt.irq;
+                        const int rc =
+                            async_req_1_0(irc_phone, IRC_ENABLE_INTERRUPT, irq);
                         if (rc != EOK) {
                                 async_hangup(irc_phone);
@@ -332 +328 @@
 
         if (match_id_str == NULL) {
-                printf(NAME ": out of memory creating match ID.\n");
+                ddf_msg(LVL_ERROR, "Out of memory creating match ID.");
                 return;
         }
@@ -338 +334 @@
         rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 90);
         if (rc != EOK) {
-                printf(NAME ": error adding match ID: %s\n",
+                ddf_msg(LVL_ERROR, "Failed adding match ID: %s",
                     str_error(rc));
         }
@@ -435 +431 @@
         
         if (range_addr != 0) {
-                printf(NAME ": function %s : ", fun->fnode->name);
-                printf("address = %" PRIx64, range_addr);
-                printf(", size = %x\n", (unsigned int) range_size);
+                ddf_msg(LVL_DEBUG, "Function %s : address = %" PRIx64
+                    ", size = %x", fun->fnode->name, range_addr,
+                    (unsigned int) range_size);
         }
         
@@ -462 +458 @@
         hw_res_list->count++;
         
-        printf(NAME ": function %s uses irq %x.\n", fun->fnode->name, irq);
+        ddf_msg(LVL_NOTE, "Function %s uses irq %x.", fun->fnode->name, irq);
 }
 
@@ -518 +514 @@
                         char *fun_name = pci_fun_create_name(fun);
                         if (fun_name == NULL) {
-                                printf(NAME ": out of memory.\n");
+                                ddf_msg(LVL_ERROR, "Out of memory.");
                                 return;
                         }
@@ -524 +520 @@
                         fnode = ddf_fun_create(bus->dnode, fun_inner, fun_name);
                         if (fnode == NULL) {
-                                printf(NAME ": error creating function.\n");
+                                ddf_msg(LVL_ERROR, "Failed creating function.");
                                 return;
                         }
@@ -538 +534 @@
                         fnode->driver_data = fun;
                         
-                        printf(NAME ": adding new function %s.\n",
+                        ddf_msg(LVL_DEBUG, "Adding new function %s.",
                             fnode->name);
                         
@@ -555 +551 @@
                                 child_bus = pci_conf_read_8(fun,
                                     PCI_BRIDGE_SEC_BUS_NUM);
-                                printf(NAME ": device is pci-to-pci bridge, "
-                                    "secondary bus number = %d.\n", bus_num);
+                                ddf_msg(LVL_DEBUG, "Device is pci-to-pci "
+                                    "bridge, secondary bus number = %d.",
+                                    bus_num);
                                 if (child_bus > bus_num)
                                         pci_bus_scan(bus, child_bus);
@@ -578 +575 @@
         int rc;
         
-        printf(NAME ": pci_add_device\n");
+        ddf_msg(LVL_DEBUG, "pci_add_device");
         dnode->parent_phone = -1;
         
         bus = pci_bus_new();
         if (bus == NULL) {
-                printf(NAME ": pci_add_device allocation failed.\n");
+                ddf_msg(LVL_ERROR, "pci_add_device allocation failed.");
                 rc = ENOMEM;
                 goto fail;
@@ -593 +590 @@
             IPC_FLAG_BLOCKING);
         if (dnode->parent_phone < 0) {
-                printf(NAME ": pci_add_device failed to connect to the "
-                    "parent's driver.\n");
+                ddf_msg(LVL_ERROR, "pci_add_device failed to connect to the "
+                    "parent's driver.");
                 rc = dnode->parent_phone;
                 goto fail;
@@ -603 +600 @@
         rc = hw_res_get_resource_list(dnode->parent_phone, &hw_resources);
         if (rc != EOK) {
-                printf(NAME ": pci_add_device failed to get hw resources for "
-                    "the device.\n");
+                ddf_msg(LVL_ERROR, "pci_add_device failed to get hw resources "
+                    "for the device.");
                 goto fail;
         }
         got_res = true;
         
-        printf(NAME ": conf_addr = %" PRIx64 ".\n",
+        ddf_msg(LVL_DEBUG, "conf_addr = %" PRIx64 ".",
             hw_resources.resources[0].res.io_range.address);
         
@@ -621 +618 @@
         if (pio_enable((void *)(uintptr_t)bus->conf_io_addr, 8,
             &bus->conf_addr_port)) {
-                printf(NAME ": failed to enable configuration ports.\n");
+                ddf_msg(LVL_ERROR, "Failed to enable configuration ports.");
                 rc = EADDRNOTAVAIL;
                 goto fail;
@@ -628 +625 @@
         
         /* Make the bus device more visible. It has no use yet. */
-        printf(NAME ": adding a 'ctl' function\n");
+        ddf_msg(LVL_DEBUG, "Adding a 'ctl' function");
         
         ctl = ddf_fun_create(bus->dnode, fun_exposed, "ctl");
         if (ctl == NULL) {
-                printf(NAME ": error creating control function.\n");
+                ddf_msg(LVL_ERROR, "Failed creating control function.");
                 rc = ENOMEM;
                 goto fail;
@@ -639 +636 @@
         rc = ddf_fun_bind(ctl);
         if (rc != EOK) {
-                printf(NAME ": error binding control function.\n");
+                ddf_msg(LVL_ERROR, "Failed binding control function.");
                 goto fail;
         }
         
         /* Enumerate functions. */
-        printf(NAME ": scanning the bus\n");
+        ddf_msg(LVL_DEBUG, "Scanning the bus");
         pci_bus_scan(bus, 0);
         
@@ -666 +663 @@
 static void pciintel_init(void)
 {
+        ddf_log_init(NAME, LVL_ERROR);
         pci_fun_ops.interfaces[HW_RES_DEV_IFACE] = &pciintel_hw_res_ops;
         pci_fun_ops.interfaces[PCI_DEV_IFACE] = &pci_dev_ops;
@@ -745 +743 @@
 int main(int argc, char *argv[])
 {
-        printf(NAME ": HelenOS pci bus driver (intel method 1).\n");
+        printf(NAME ": HelenOS PCI bus driver (Intel method 1).\n");
         pciintel_init();
         return ddf_driver_main(&pci_driver);