Changeset 5c8ba05 in mainline for kernel/generic/include/synch/waitq.h

Timestamp:

2007-05-07T18:52:24Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6fa4888b

Parents:

4f42d52

Message:

Cleanup the waitq_wakeup() interface.
Replace numeric constants (i.e. 0)
and boolean constants (i.e. false) with
more readable WAKEUP_FIRST. Also change the
type of the second argument of waitq_wakeup()
to a newly introduced type wakeup_mode_t.

Fix behaviour of waitq_wakeup() in case
that WAKEUP_ALL semantics is required
but no threads are sleeping in the wait
queue. This is a similar fix to that of
Jan Hudecek committed in the RCU branch,
but, IMHO, is more straightforward and
also doesn't eat up previous missed
wakeups.

File:

• kernel/generic/include/synch/waitq.h (modified) (2 diffs)

kernel/generic/include/synch/waitq.h

@@ -41 +41 @@
 #include <adt/list.h>
 
-#define WAKEUP_FIRST    0
-#define WAKEUP_ALL      1
+typedef enum {
+        WAKEUP_FIRST = 0,
+        WAKEUP_ALL
+} wakeup_mode_t;
 
 /** Wait queue structure. */
@@ -71 +73 @@
 extern int waitq_sleep_timeout_unsafe(waitq_t *wq, uint32_t usec, int flags);
 extern void waitq_sleep_finish(waitq_t *wq, int rc, ipl_t ipl);
-extern void waitq_wakeup(waitq_t *wq, bool all);
-extern void _waitq_wakeup_unsafe(waitq_t *wq, bool all);
+extern void waitq_wakeup(waitq_t *wq, wakeup_mode_t mode);
+extern void _waitq_wakeup_unsafe(waitq_t *wq, wakeup_mode_t mode);
 extern void waitq_interrupt_sleep(struct thread *t);