Changeset 5c8ba05 in mainline for kernel/generic/src/ipc/ipc.c

Timestamp:

2007-05-07T18:52:24Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6fa4888b

Parents:

4f42d52

Message:

Cleanup the waitq_wakeup() interface.
Replace numeric constants (i.e. 0)
and boolean constants (i.e. false) with
more readable WAKEUP_FIRST. Also change the
type of the second argument of waitq_wakeup()
to a newly introduced type wakeup_mode_t.

Fix behaviour of waitq_wakeup() in case
that WAKEUP_ALL semantics is required
but no threads are sleeping in the wait
queue. This is a similar fix to that of
Jan Hudecek committed in the RCU branch,
but, IMHO, is more straightforward and
also doesn't eat up previous missed
wakeups.

File:

• kernel/generic/src/ipc/ipc.c (modified) (2 diffs)

kernel/generic/src/ipc/ipc.c

@@ -164 +164 @@
         list_append(&call->link, &callerbox->answers);
         spinlock_unlock(&callerbox->lock);
-        waitq_wakeup(&callerbox->wq, 0);
+        waitq_wakeup(&callerbox->wq, WAKEUP_FIRST);
 }
 
@@ -206 +206 @@
         list_append(&call->link, &box->calls);
         spinlock_unlock(&box->lock);
-        waitq_wakeup(&box->wq, 0);
+        waitq_wakeup(&box->wq, WAKEUP_FIRST);
 }