Changes in / [682b697:5d4eb2df] in mainline

Location:

uspace

Files:

• app/virtusbkbd/virtusbkbd.c (modified) (1 diff)
• drv/usbhub/main.c (modified) (1 diff)
• drv/usbhub/utils.c (modified) (7 diffs)
• drv/vhc/devices.c (modified) (1 diff)
• drv/vhc/hubops.c (modified) (1 diff)
• lib/usb/src/addrkeep.c (modified) (1 diff)

uspace/app/virtusbkbd/virtusbkbd.c

@@ -223 +223 @@
         
         printf("%s: Simulating keyboard events...\n", NAME);
-        while(1){
-                kb_process_events(&status, keyboard_events, keyboard_events_count,
-                        on_keyboard_change);
-        }
+        kb_process_events(&status, keyboard_events, keyboard_events_count,
+            on_keyboard_change);
         
         printf("%s: Terminating...\n", NAME);

uspace/drv/usbhub/main.c

@@ -50 +50 @@
         while(true){
                 usb_hub_check_hub_changes();
-                async_usleep(10000000);
+                async_usleep(10000);
         }
         return 0;

uspace/drv/usbhub/utils.c

@@ -352 +352 @@
         result->port_count = descriptor->ports_count;
         result->attached_devs = (usb_hub_attached_device_t*)
-            malloc((result->port_count+1) * sizeof(usb_hub_attached_device_t));
+            malloc(result->port_count * sizeof(usb_hub_attached_device_t));
         int i;
-        for(i=0;i<result->port_count+1;++i){
+        for(i=0;i<result->port_count;++i){
                 result->attached_devs[i].devman_handle=0;
                 result->attached_devs[i].address=0;
@@ -428 +428 @@
 
 
-        for (port = 1; port < hub_info->port_count+1; ++port) {
+        for (port = 0; port < hub_info->port_count; ++port) {
                 usb_hub_set_power_port_request(&request, port);
                 opResult = usb_drv_sync_control_write(hc, target, &request, NULL, 0);
-                printf("[usb_hub] powering port %d\n",port);
                 if (opResult != EOK) {
                         printf("[usb_hub]something went wrong when setting hub`s %dth port\n", port);
@@ -541 +540 @@
                 return;
         }
-        printf("[usb_hub] new device address %d, handle %d\n",
-            new_device_address, child_handle);
-        sleep(60);
         
 }
@@ -642 +638 @@
         usb_port_set_dev_connected(&status, false);
         if (status) {
-                printf("[usb_hub]there was some unsupported change on port %d\n",port);
+                printf("[usb_hub]there was some unsupported change on port\n");
         }
         /// \TODO handle other changes
@@ -679 +675 @@
                 target.address = hub_info->usb_device->address;
                 target.endpoint = 1;/// \TODO get from endpoint descriptor
-                printf("checking changes for hub at addr %d \n",target.address);
 
                 size_t port_count = hub_info->port_count;
@@ -692 +687 @@
 
                 // FIXME: count properly
-                size_t byte_length = ((port_count+1) / 8) + 1;
+                size_t byte_length = (port_count / 8) + 1;
 
                 void *change_bitmap = malloc(byte_length);
@@ -712 +707 @@
                 }
                 unsigned int port;
-                for (port = 1; port < port_count+1; ++port) {
+                for (port = 0; port < port_count; ++port) {
                         bool interrupt = (((uint8_t*) change_bitmap)[port / 8] >> (port % 8)) % 2;
                         if (interrupt) {

uspace/drv/vhc/devices.c

@@ -147 +147 @@
         if (virthub_dev.address == transaction->target.address) {
                 size_t tmp;
-                dprintf(1, "sending `%s' transaction to hub",
+                dprintf(3, "sending `%s' transaction to hub",
                     usbvirt_str_transaction_type(transaction->type));
                 switch (transaction->type) {

uspace/drv/vhc/hubops.c

@@ -200 +200 @@
                 } \
         } while (false); \
-        hub_port_t *portvar = &hub_dev.ports[index-1]
+        hub_port_t *portvar = &hub_dev.ports[index]
 
 

uspace/lib/usb/src/addrkeep.c

@@ -199 +199 @@
                         usb_address_keeping_used_t *last
                             = used_address_get_instance(addresses->used_addresses.next);
-                        free_address = last->address + 1;
+                        free_address = last->address;
                 }
         }