Changes in uspace/drv/bus/usb/usbmast/main.c [fbcdeb8:5f6e25e] in mainline

File:

• uspace/drv/bus/usb/usbmast/main.c (modified) (12 diffs)

uspace/drv/bus/usb/usbmast/main.c

@@ -55 +55 @@
 #define GET_BULK_OUT(dev) ((dev)->pipes[BULK_OUT_EP].pipe)
 
-static const usb_endpoint_description_t bulk_in_ep = {
+static usb_endpoint_description_t bulk_in_ep = {
         .transfer_type = USB_TRANSFER_BULK,
         .direction = USB_DIRECTION_IN,
@@ -63 +63 @@
         .flags = 0
 };
-static const usb_endpoint_description_t bulk_out_ep = {
+static usb_endpoint_description_t bulk_out_ep = {
         .transfer_type = USB_TRANSFER_BULK,
         .direction = USB_DIRECTION_OUT,
@@ -72 +72 @@
 };
 
-static const usb_endpoint_description_t *mast_endpoints[] = {
+usb_endpoint_description_t *mast_endpoints[] = {
         &bulk_in_ep,
         &bulk_out_ep,
@@ -82 +82 @@
     void *arg);
 
-/** Callback when a device is removed from the system.
- *
- * @param dev Representation of USB device.
+/** Callback when new device is attached and recognized as a mass storage.
+ *
+ * @param dev Representation of a the USB device.
  * @return Error code.
  */
-static int usbmast_device_gone(usb_device_t *dev)
-{
-        usbmast_dev_t *mdev = dev->driver_data;
-        assert(mdev);
-
-        for (size_t i = 0; i < mdev->lun_count; ++i) {
-                const int rc = ddf_fun_unbind(mdev->luns[i]);
-                if (rc != EOK) {
-                        usb_log_error("Failed to unbind LUN function %zu: "
-                            "%s\n", i, str_error(rc));
-                        return rc;
-                }
-                ddf_fun_destroy(mdev->luns[i]);
-                mdev->luns[i] = NULL;
-        }
-        free(mdev->luns);
-        return EOK;
-}
-
-/** Callback when a device is about to be removed.
- *
- * @param dev Representation of USB device.
- * @return Error code.
- */
-static int usbmast_device_remove(usb_device_t *dev)
-{
-        //TODO: flush buffers, or whatever.
-        //TODO: remove device
-        return ENOTSUP;
-}
-
-/** Callback when new device is attached and recognized as a mass storage.
- *
- * @param dev Representation of USB device.
- * @return Error code.
- */
-static int usbmast_device_add(usb_device_t *dev)
+static int usbmast_add_device(usb_device_t *dev)
 {
         int rc;
@@ -130 +94 @@
 
         /* Allocate softstate */
-        mdev = usb_device_data_alloc(dev, sizeof(usbmast_dev_t));
+        mdev = calloc(1, sizeof(usbmast_dev_t));
         if (mdev == NULL) {
                 usb_log_error("Failed allocating softstate.\n");
-                return ENOMEM;
+                rc = ENOMEM;
+                goto error;
         }
 
@@ -139 +104 @@
         mdev->usb_dev = dev;
 
-        usb_log_info("Initializing mass storage `%s'.\n", dev->ddf_dev->name);
-        usb_log_debug("Bulk in endpoint: %d [%zuB].\n",
-            dev->pipes[BULK_IN_EP].pipe.endpoint_no,
-            dev->pipes[BULK_IN_EP].pipe.max_packet_size);
+        usb_log_info("Initializing mass storage `%s'.\n",
+            dev->ddf_dev->name);
+        usb_log_debug(" Bulk in endpoint: %d [%zuB].\n",
+            dev->pipes[BULK_IN_EP].pipe->endpoint_no,
+            (size_t) dev->pipes[BULK_IN_EP].descriptor->max_packet_size);
         usb_log_debug("Bulk out endpoint: %d [%zuB].\n",
-            dev->pipes[BULK_OUT_EP].pipe.endpoint_no,
-            dev->pipes[BULK_OUT_EP].pipe.max_packet_size);
+            dev->pipes[BULK_OUT_EP].pipe->endpoint_no,
+            (size_t) dev->pipes[BULK_OUT_EP].descriptor->max_packet_size);
 
         usb_log_debug("Get LUN count...\n");
-        mdev->lun_count = usb_masstor_get_lun_count(mdev);
-        mdev->luns = calloc(mdev->lun_count, sizeof(ddf_fun_t*));
-        if (mdev->luns == NULL) {
-                rc = ENOMEM;
-                usb_log_error("Failed allocating luns table.\n");
-                goto error;
-        }
-
-        for (i = 0; i < mdev->lun_count; i++) {
+        mdev->luns = usb_masstor_get_lun_count(mdev);
+
+        for (i = 0; i < mdev->luns; i++) {
                 rc = usbmast_fun_create(mdev, i);
                 if (rc != EOK)
@@ -164 +124 @@
         return EOK;
 error:
-        /* Destroy functions */
-        for (size_t i = 0; i < mdev->lun_count; ++i) {
-                if (mdev->luns[i] == NULL)
-                        continue;
-                const int rc = ddf_fun_unbind(mdev->luns[i]);
-                if (rc != EOK) {
-                        usb_log_warning("Failed to unbind LUN function %zu: "
-                            "%s.\n", i, str_error(rc));
-                }
-                ddf_fun_destroy(mdev->luns[i]);
-        }
-        free(mdev->luns);
+        /* XXX Destroy functions */
+        if (mdev != NULL)
+                free(mdev);
         return rc;
 }
@@ -207 +158 @@
         }
 
+        free(fun_name);
+
         /* Allocate soft state */
-        mfun = ddf_fun_data_alloc(fun, sizeof(usbmast_fun_t));
+        mfun = ddf_dev_data_alloc(mdev->ddf_dev, sizeof(usbmast_fun_t));
         if (mfun == NULL) {
                 usb_log_error("Failed allocating softstate.\n");
@@ -215 +168 @@
         }
 
-        mfun->ddf_fun = fun;
         mfun->mdev = mdev;
         mfun->lun = lun;
 
+        fun_name = NULL;
+
         /* Set up a connection handler. */
         fun->conn_handler = usbmast_bd_connection;
+        fun->driver_data = mfun;
 
         usb_log_debug("Inquire...\n");
@@ -264 +219 @@
                 goto error;
         }
-
-        free(fun_name);
-        mdev->luns[lun] = fun;
 
         return EOK;
@@ -300 +252 @@
                 return;
         }
-        
-        (void) async_share_out_finalize(callid, &comm_buf);
-        if (comm_buf == (void *) -1) {
+
+        comm_buf = as_get_mappable_page(comm_size);
+        if (comm_buf == NULL) {
                 async_answer_0(callid, EHANGUP);
                 return;
         }
-        
+
+        (void) async_share_out_finalize(callid, comm_buf);
+
         mfun = (usbmast_fun_t *) ((ddf_fun_t *)arg)->driver_data;
 
@@ -346 +300 @@
 
 /** USB mass storage driver ops. */
-static const usb_driver_ops_t usbmast_driver_ops = {
-        .device_add = usbmast_device_add,
-        .device_rem = usbmast_device_remove,
-        .device_gone = usbmast_device_gone,
+static usb_driver_ops_t usbmast_driver_ops = {
+        .add_device = usbmast_add_device,
 };
 
 /** USB mass storage driver. */
-static const usb_driver_t usbmast_driver = {
+static usb_driver_t usbmast_driver = {
         .name = NAME,
         .ops = &usbmast_driver_ops,