Changeset 5f9b4d9a in mainline

Timestamp:

2006-10-16T21:09:25Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fc46884

Parents:

2b017ba

Message:

For the sake of clarity, get rid of negative INR for virtual interrupts.
This way, the code can hurt performance on systems where the non-negative klog INR overlaps
with a frequently used INR such as system clock on amd64 and ia32.

Location:

kernel/generic

Files:

• include/ipc/irq.h (modified) (1 diff)
• src/console/klog.c (modified) (2 diffs)

kernel/generic/include/ipc/irq.h

@@ -38 +38 @@
 /** Maximum length of IPC IRQ program */
 #define IRQ_MAX_PROG_SIZE 10
-
-#define VIRT_INR_KLOG           -2
-#define VIRT_INR_KBDRESTART     -3
 
 typedef enum {

kernel/generic/src/console/klog.c

@@ -41 +41 @@
 #include <ipc/irq.h>
 
+/*
+ * For now, we use 0 as INR.
+ * However, on some architectures 0 is the clock interrupt (e.g. amd64 and ia32).
+ * It is therefore desirable to have architecture specific definition of KLOG_VIRT_INR
+ * in the future.
+ */
+#define KLOG_VIRT_INR   0
+
 /* Order of frame to be allocated for klog communication */
 #define KLOG_ORDER      0
@@ -75 +83 @@
         sysinfo_set_item_val("klog.pages", NULL, 1 << KLOG_ORDER);
         sysinfo_set_item_val("klog.devno", NULL, devno);
-        sysinfo_set_item_val("klog.inr", NULL, VIRT_INR_KLOG); 
+        sysinfo_set_item_val("klog.inr", NULL, KLOG_VIRT_INR);
 
         irq_initialize(&klog_irq);
         klog_irq.devno = devno;
-        klog_irq.inr = VIRT_INR_KLOG;
+        klog_irq.inr = KLOG_VIRT_INR;
         klog_irq.claim = klog_claim;
         irq_register(&klog_irq);