Changeset 6212095 in mainline

Timestamp:

2006-05-28T10:01:08Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c93e805

Parents:

46fc2f9

Message:

Make ddi_physmem_map() accept address space area flags instead of writable switch.
Thus even these types of address space areas can turn caching on, if it is desired.

Location:

generic

Files:

• include/ddi/ddi_arg.h (modified) (1 diff)
• src/ddi/ddi.c (modified) (4 diffs)

generic/include/ddi/ddi_arg.h

@@ -36 +36 @@
         void *virt_base;                /** Virtual address of starting page. */
         unsigned long pages;            /** Number of pages to map. */
-        int writable;                   /** True if the mapping should be writable. */
+        int flags;                      /** Address space area flags for the mapping. */
 } ddi_memarg_t;
 

generic/src/ddi/ddi.c

@@ -54 +54 @@
  * @param vp Virtual page address of the starting page.
  * @param pages Number of pages to map.
- * @param writable If true, the mapping will be created writable.
+ * @param flags Address space area flags for the mapping.
  *
  * @return 0 on success, EPERM if the caller lacks capabilities to use this syscall,
@@ -60 +60 @@
  *         there was a problem in creating address space area.
  */
-static int ddi_physmem_map(task_id_t id, __address pf, __address vp, count_t pages, bool writable)
+static int ddi_physmem_map(task_id_t id, __address pf, __address vp, count_t pages, int flags)
 {
         ipl_t ipl;
         cap_t caps;
         task_t *t;
-        int flags;
         mem_backend_data_t backend_data;
 
@@ -102 +101 @@
         spinlock_unlock(&tasks_lock);
         
-        flags = AS_AREA_READ;
-        if (writable)
-                flags |= AS_AREA_WRITE;
         if (!as_area_create(t->as, flags, pages * PAGE_SIZE, vp, AS_AREA_ATTR_NONE,
                 &phys_backend, &backend_data)) {
@@ -196 +192 @@
         return (__native) ddi_physmem_map((task_id_t) arg.task_id, ALIGN_DOWN((__address) arg.phys_base, FRAME_SIZE),
                                           ALIGN_DOWN((__address) arg.virt_base, PAGE_SIZE), (count_t) arg.pages,
-                                          (bool) arg.writable);
+                                          (int) arg.flags);
 }