Changeset 62f8025 in mainline

Timestamp:

2017-10-28T22:47:06Z (7 years ago)

Author:

Petr Manek <petr.manek@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9620a54

Parents:

6b2930b

Message:

Centrally disabled deallocation of endpoint-related data structures due to memory corruption. This is better than commenting out every single usage.

Location:

uspace/drv/bus/usb/xhci

Files:

• bus.c (modified) (1 diff)
• endpoint.c (modified) (1 diff)

uspace/drv/bus/usb/xhci/bus.c

@@ -439 +439 @@
         /* Tear down TRB ring / PSA. */
         /* TODO: Make this method "noexcept" */
-        /* FIXME: There is some memory corruption going on, causing this to crash. */
-        /*if ((err = xhci_endpoint_free_transfer_ds(ep))) {
+        if ((err = xhci_endpoint_free_transfer_ds(ep))) {
                 usb_log_error("Failed to free resources of an endpoint.");
-        }*/
+        }
 
         return EOK;

uspace/drv/bus/usb/xhci/endpoint.c

@@ -203 +203 @@
 int xhci_endpoint_free_transfer_ds(xhci_endpoint_t *xhci_ep)
 {
+        /* FIXME: For some reason (possibly memory corruption), this crashes. */
+        return EOK;
+
         if (endpoint_using_streams(xhci_ep)) {
                 usb_log_debug2("Freeing primary stream context array for endpoint " XHCI_EP_FMT, XHCI_EP_ARGS(*xhci_ep));