Changeset 65267f6 in mainline for uspace/app/bdsh/cmds/modules/mkdir/mkdir.c

Timestamp:

2008-08-23T08:35:06Z (16 years ago)

Author:

Tim Post <echo@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c9f5e24f

Parents:

eb9618c

Message:

mkdir: Get rid of useless while loop (spaghetti)

File:

• uspace/app/bdsh/cmds/modules/mkdir/mkdir.c (modified) (2 diffs)

uspace/app/bdsh/cmds/modules/mkdir/mkdir.c

@@ -148 +148 @@
 
         while (dirs[i] != NULL) {
-                /* Rewind to start of relative path */
-                while (!strcmp(dirs[i], "..")) {
+                /* Sometimes make or scripts conjoin odd paths. Account for something
+                 * like this: ../../foo/bar/../foo/foofoo/./bar */
+                if (!strcmp(dirs[i], "..") || !strcmp(dirs[i], ".")) {
                         if (0 != (chdir(dirs[i]))) {
                                 cli_error(CL_EFAIL, "%s: impossible path: %s",
@@ -156 +157 @@
                                 goto finit;
                         }
-                        i++;
-                }
-                getcwd(wdp, PATH_MAX);
-                /* Sometimes make or scripts conjoin odd paths. Account for something
-                 * like this: ../../foo/bar/../foo/foofoo/./bar */
-                if (!strcmp(dirs[i], "..") || !strcmp(dirs[i], ".")) {
-                        chdir(dirs[i]);
                         getcwd(wdp, PATH_MAX);
                 } else {