Changes in uspace/drv/uhci-hcd/uhci.c [05ead5c:68b5ed6e] in mainline

File:

• uspace/drv/uhci-hcd/uhci.c (modified) (10 diffs)

uspace/drv/uhci-hcd/uhci.c ¶

@@ -54 +54 @@
 {
         assert(dev);
-        hc_t *hc = &((uhci_t*)dev->driver_data)->hc;
+        uhci_hc_t *hc = &((uhci_t*)dev->driver_data)->hc;
         uint16_t status = IPC_GET_ARG1(*call);
         assert(hc);
-        hc_interrupt(hc, status);
+        uhci_hc_interrupt(hc, status);
 }
 /*----------------------------------------------------------------------------*/
@@ -70 +70 @@
 {
         assert(fun);
-        usb_device_keeper_t *manager = &((uhci_t*)fun->dev->driver_data)->hc.manager;
+        usb_device_keeper_t *manager = &((uhci_t*)fun->dev->driver_data)->hc.device_manager;
 
         usb_address_t addr = usb_device_keeper_find(manager, handle);
@@ -107 +107 @@
 };
 /*----------------------------------------------------------------------------*/
-static ddf_dev_ops_t hc_ops = {
+static ddf_dev_ops_t uhci_hc_ops = {
         .interfaces[USB_DEV_IFACE] = &usb_iface,
-        .interfaces[USBHC_DEV_IFACE] = &hc_iface, /* see iface.h/c */
+        .interfaces[USBHC_DEV_IFACE] = &uhci_hc_iface, /* see iface.h/c */
 };
 /*----------------------------------------------------------------------------*/
@@ -120 +120 @@
 {
         assert(fun);
-        return &((rh_t*)fun->driver_data)->resource_list;
+        return &((uhci_rh_t*)fun->driver_data)->resource_list;
 }
 /*----------------------------------------------------------------------------*/
@@ -128 +128 @@
 };
 /*----------------------------------------------------------------------------*/
-static ddf_dev_ops_t rh_ops = {
+static ddf_dev_ops_t uhci_rh_ops = {
         .interfaces[USB_DEV_IFACE] = &usb_iface,
         .interfaces[HW_RES_DEV_IFACE] = &hw_res_iface
@@ -167 +167 @@
         CHECK_RET_DEST_FUN_RETURN(ret,
             "Failed(%d) to get I/O addresses:.\n", ret, device->handle);
-        usb_log_debug("I/O regs at 0x%X (size %zu), IRQ %d.\n",
+        usb_log_info("I/O regs at 0x%X (size %zu), IRQ %d.\n",
             io_reg_base, io_reg_size, irq);
 
@@ -175 +175 @@
 
         bool interrupts = false;
-#ifdef CONFIG_USBHC_NO_INTERRUPTS
-        usb_log_warning("Interrupts disabled in OS config, " \
-            "falling back to polling.\n");
-#else
         ret = pci_enable_interrupts(device);
         if (ret != EOK) {
-                usb_log_warning("Failed to enable interrupts: %s.\n",
-                    str_error(ret));
-                usb_log_info("HW interrupts not available, " \
-                    "falling back to polling.\n");
+                usb_log_warning(
+                    "Failed(%d) to enable interrupts, fall back to polling.\n",
+                    ret);
         } else {
                 usb_log_debug("Hw interrupts enabled.\n");
                 interrupts = true;
         }
-#endif
 
         instance->hc_fun = ddf_fun_create(device, fun_exposed, "uhci-hc");
@@ -196 +190 @@
             "Failed(%d) to create HC function.\n", ret);
 
-        ret = hc_init(&instance->hc, instance->hc_fun,
+        ret = uhci_hc_init(&instance->hc, instance->hc_fun,
             (void*)io_reg_base, io_reg_size, interrupts);
         CHECK_RET_DEST_FUN_RETURN(ret, "Failed(%d) to init uhci-hcd.\n", ret);
-        instance->hc_fun->ops = &hc_ops;
+        instance->hc_fun->ops = &uhci_hc_ops;
         instance->hc_fun->driver_data = &instance->hc;
         ret = ddf_fun_bind(instance->hc_fun);
@@ -214 +208 @@
         if (instance->rh_fun) \
                 ddf_fun_destroy(instance->rh_fun); \
-        hc_fini(&instance->hc); \
+        uhci_hc_fini(&instance->hc); \
         return ret; \
 }
@@ -229 +223 @@
             "Failed(%d) to create root hub function.\n", ret);
 
-        ret = rh_init(&instance->rh, instance->rh_fun,
+        ret = uhci_rh_init(&instance->rh, instance->rh_fun,
             (uintptr_t)instance->hc.registers + 0x10, 4);
         CHECK_RET_FINI_RETURN(ret,
             "Failed(%d) to setup UHCI root hub.\n", ret);
 
-        instance->rh_fun->ops = &rh_ops;
+        instance->rh_fun->ops = &uhci_rh_ops;
         instance->rh_fun->driver_data = &instance->rh;
         ret = ddf_fun_bind(instance->rh_fun);