Changes in uspace/drv/ohci/root_hub.c [b2387c2:6ab7f3e9] in mainline

File:

• uspace/drv/ohci/root_hub.c (modified) (4 diffs)

uspace/drv/ohci/root_hub.c

@@ -57 +57 @@
         .device_version = 0,
         .length = sizeof (usb_standard_device_descriptor_t),
+        /// \TODO this value is guessed
         .max_packet_size = 8,
         .vendor_id = 0x16db,
@@ -467 +468 @@
 
         usb_hub_bm_request_type_t request_type = request_packet->request_type;
-        if (buffer_size < 4) {
+        if (buffer_size < 4/*request_packet->length*/) {///\TODO
                 usb_log_warning("requested more data than buffer size\n");
                 return EINVAL;
@@ -677 +678 @@
             (instance->registers->rh_port_status[port - 1] | (1 << feature))
             & (~port_clear_feature_valid_mask);
+        /// \TODO any error?
+
         return EOK;
 }
@@ -704 +707 @@
             & (~port_clear_feature_valid_mask))
             | (1 << feature);
+        /// \TODO any error?
 
         return EOK;