Changeset 6afc9d7 in mainline for uspace/app/bdsh/cmds/modules/ls/ls.c

Timestamp:

2015-10-06T19:01:36Z (9 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0328987

Parents:

f1f7584

Message:

UNIX-like I/O functions should use errno to return error code for many reasons.

File:

• uspace/app/bdsh/cmds/modules/ls/ls.c (modified) (4 diffs)

uspace/app/bdsh/cmds/modules/ls/ls.c

@@ -31 +31 @@
  * As more stuff is completed and exposed in libc, this will improve */
 
+#include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -187 +188 @@
                 if (rc != 0) {
                         printf("ls: skipping bogus node %s\n", buff);
-                        printf("rc=%d\n", rc);
+                        printf("error=%d\n", errno);
                         goto out;
                 }
@@ -314 +315 @@
 static unsigned int ls_scope(const char *path, struct dir_elem_t *de)
 {
-        if (stat(path, &de->s)) {
+        if (stat(path, &de->s) != 0) {
                 cli_error(CL_ENOENT, "%s", path);
                 return LS_BOGUS;
@@ -376 +377 @@
                 }
         }
-        
+
         argc -= optind;
-        
+
         de.name = (char *) malloc(PATH_MAX);
         if (!de.name) {
-                cli_error(CL_ENOMEM, "%s: ", cmdname);
+                cli_error(CL_ENOMEM, "%s: Out of memory", cmdname);
                 return CMD_FAILURE;
         }
         memset(de.name, 0, PATH_MAX);
-        
-        if (argc == 0)
-                getcwd(de.name, PATH_MAX);
-        else
+
+        if (argc == 0) {
+                if (getcwd(de.name, PATH_MAX) == NULL) {
+                        cli_error(CL_EFAIL, "%s: Failed determining working "
+                            "directory", cmdname);
+                        return CMD_FAILURE;
+                }
+        } else {
                 str_cpy(de.name, PATH_MAX, argv[optind]);
+        }
 
         scope = ls_scope(de.name, &de);