Changeset 6f122df in mainline

Timestamp:

2011-04-22T21:25:19Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77d10f0

Parents:

9bff1ea

Message:

Add more comments about qemu interrupt bug

Remove some redundant pointer casts.

File:

• uspace/drv/uhci-hcd/hc.c (modified) (3 diffs)

uspace/drv/uhci-hcd/hc.c

@@ -330 +330 @@
 {
         assert(instance);
-//      status |= 1; //Uncomment to work around qemu hang
         /* Lower 2 bits are transaction error and transaction complete */
         if (status & (UHCI_STATUS_INTERRUPT | UHCI_STATUS_ERROR_INTERRUPT)) {
@@ -380 +379 @@
 {
         usb_log_debug("Started interrupt emulator.\n");
-        hc_t *instance = (hc_t*)arg;
+        hc_t *instance = arg;
         assert(instance);
 
         while (1) {
-                /* Readd and clear status register */
+                /* Read and clear status register */
                 uint16_t status = pio_read_16(&instance->registers->usbsts);
                 pio_write_16(&instance->registers->usbsts, status);
                 if (status != 0)
                         usb_log_debug2("UHCI status: %x.\n", status);
+// Qemu fails to report stalled communication
+// see https://bugs.launchpad.net/qemu/+bug/757654
+// This is a simple workaround to force queue processing every time
+        //      status |= 1;
                 hc_interrupt(instance, status);
                 async_usleep(UHCI_INT_EMULATOR_TIMEOUT);
@@ -402 +405 @@
 int hc_debug_checker(void *arg)
 {
-        hc_t *instance = (hc_t*)arg;
+        hc_t *instance = arg;
         assert(instance);