Changes in kernel/generic/src/console/console.c [d7533c7:712c4ba] in mainline

File:

• kernel/generic/src/console/console.c (modified) (8 diffs)

kernel/generic/src/console/console.c

@@ -53 +53 @@
 #include <str.h>
 
-#define KLOG_PAGES    4
+#define KLOG_PAGES    8
 #define KLOG_LENGTH   (KLOG_PAGES * PAGE_SIZE / sizeof(wchar_t))
-#define KLOG_LATENCY  8
 
 /** Kernel log cyclic buffer */
@@ -61 +60 @@
 
 /** Kernel log initialized */
-static bool klog_inited = false;
+static atomic_t klog_inited = {false};
 
 /** First kernel log characters */
@@ -76 +75 @@
 
 /** Kernel log spinlock */
-SPINLOCK_STATIC_INITIALIZE_NAME(klog_lock, "*klog_lock");
+SPINLOCK_STATIC_INITIALIZE_NAME(klog_lock, "klog_lock");
 
 /** Physical memory area used for klog buffer */
@@ -166 +165 @@
         sysinfo_set_item_val("klog.pages", NULL, KLOG_PAGES);
         
-        spinlock_lock(&klog_lock);
-        klog_inited = true;
-        spinlock_unlock(&klog_lock);
+        event_set_unmask_callback(EVENT_KLOG, klog_update);
+        atomic_set(&klog_inited, true);
 }
 
@@ -263 +261 @@
 void klog_update(void)
 {
+        if (!atomic_get(&klog_inited))
+                return;
+        
         spinlock_lock(&klog_lock);
         
-        if ((klog_inited) && (event_is_subscribed(EVENT_KLOG)) && (klog_uspace > 0)) {
-                event_notify_3(EVENT_KLOG, klog_start, klog_len, klog_uspace);
-                klog_uspace = 0;
+        if (klog_uspace > 0) {
+                if (event_notify_3(EVENT_KLOG, true, klog_start, klog_len,
+                    klog_uspace) == EOK)
+                        klog_uspace = 0;
         }
         
@@ -275 +277 @@
 void putchar(const wchar_t ch)
 {
+        bool ordy = ((stdout) && (stdout->op->write));
+        
         spinlock_lock(&klog_lock);
         
-        if ((klog_stored > 0) && (stdout) && (stdout->op->write)) {
-                /* Print charaters stored in kernel log */
-                size_t i;
-                for (i = klog_len - klog_stored; i < klog_len; i++)
-                        stdout->op->write(stdout, klog[(klog_start + i) % KLOG_LENGTH], silent);
-                klog_stored = 0;
+        /* Print charaters stored in kernel log */
+        if (ordy) {
+                while (klog_stored > 0) {
+                        wchar_t tmp = klog[(klog_start + klog_len - klog_stored) % KLOG_LENGTH];
+                        klog_stored--;
+                        
+                        /*
+                         * We need to give up the spinlock for
+                         * the physical operation of writting out
+                         * the character.
+                         */
+                        spinlock_unlock(&klog_lock);
+                        stdout->op->write(stdout, tmp, silent);
+                        spinlock_lock(&klog_lock);
+                }
         }
         
@@ -292 +305 @@
                 klog_start = (klog_start + 1) % KLOG_LENGTH;
         
-        if ((stdout) && (stdout->op->write))
+        if (!ordy) {
+                if (klog_stored < klog_len)
+                        klog_stored++;
+        }
+        
+        /* The character is stored for uspace */
+        if (klog_uspace < klog_len)
+                klog_uspace++;
+        
+        spinlock_unlock(&klog_lock);
+        
+        if (ordy) {
+                /*
+                 * Output the character. In this case
+                 * it should be no longer buffered.
+                 */
                 stdout->op->write(stdout, ch, silent);
-        else {
+        } else {
                 /*
                  * No standard output routine defined yet.
@@ -304 +332 @@
                  * Note that the early_putc() function might be
                  * a no-op on certain hardware configurations.
-                 *
                  */
                 early_putchar(ch);
-                
-                if (klog_stored < klog_len)
-                        klog_stored++;
-        }
-        
-        /* The character is stored for uspace */
-        if (klog_uspace < klog_len)
-                klog_uspace++;
-        
-        /* Check notify uspace to update */
-        bool update;
-        if ((klog_uspace > KLOG_LATENCY) || (ch == '\n'))
-                update = true;
-        else
-                update = false;
-        
-        spinlock_unlock(&klog_lock);
-        
-        if (update)
+        }
+        
+        /* Force notification on newline */
+        if (ch == '\n')
                 klog_update();
 }