Changeset 74359c6 in mainline for uspace/libc/generic/thread.c

Timestamp:

2006-12-30T13:36:13Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

33c0c649

Parents:

66eb2c8

Message:

Improve comments and fix formatting in (sparc64) TLS implementation.
Improve some comments and formatting in sparc64 uspace thread library
code.

Update required msim version.

File:

• uspace/libc/generic/thread.c (modified) (4 diffs)

uspace/libc/generic/thread.c

@@ -56 +56 @@
 extern char _tbss_end;
 
-/** Create Thread Local storage area, return pointer to TCB(ThreadControlBlock)
+/** Create TLS (Thread Local Storage) data structures.
  *
- * !! The code requires, that sections .tdata and .tbss are adjacent.
- *    It may be changed in the future.
+ * The code requires, that sections .tdata and .tbss are adjacent. It may be
+ * changed in the future.
+ *
+ * @return Pointer to TCB.
  */
-tcb_t * __make_tls(void)
+tcb_t *__make_tls(void)
 {
         void *data;
@@ -69 +71 @@
         tcb = __alloc_tls(&data, tls_size);
         
+        /*
+         * Copy thread local data from the initialization image.
+         */
         memcpy(data, &_tdata_start, &_tdata_end - &_tdata_start);
-        memset(data + (&_tbss_start-&_tdata_start), 0, &_tbss_end-&_tbss_start);
+        /*
+         * Zero out the thread local uninitialized data.
+         */
+        memset(data + (&_tbss_start - &_tdata_start), 0, &_tbss_end -
+                &_tbss_start);
+
         return tcb;
 }
@@ -88 +98 @@
  *
  * @param uarg Pointer to userspace argument structure.
- *
- * TODO: Thread stack pages memory leak
  */
 void __thread_main(uspace_arg_t *uarg)
@@ -125 +133 @@
         uspace_arg_t *uarg;
 
-        stack = (char *) malloc(getpagesize()*THREAD_INITIAL_STACK_PAGES_NO);
+        stack = (char *) malloc(getpagesize() * THREAD_INITIAL_STACK_PAGES_NO);
         if (!stack)
                 return -1;