Changeset 780c8ce in mainline for uspace/srv/taskman/event.c

Timestamp:

2019-08-07T05:52:27Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

012dd8e

Parents:

2aaccd3

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-10-22 23:09:22)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 05:52:27)

Message:

taskman: Light streamlining (removing TODOs)

• Low work attitude today

File:

• uspace/srv/taskman/event.c (modified) (4 diffs)

uspace/srv/taskman/event.c

@@ -189 +189 @@
 }
 
-void wait_for_task(task_id_t id, int flags, ipc_callid_t callid, ipc_call_t *call)
+void wait_for_task(task_id_t id, int flags, ipc_callid_t callid,
+     task_id_t waiter_id)
 {
         assert(!(flags & TASK_WAIT_BOTH) ||
@@ -214 +215 @@
          * wait.
          */
-        task_id_t waiter_id = call->in_task_id;
         fibril_rwlock_write_lock(&pending_wait_lock);
         pending_wait_t *pr = NULL;
@@ -264 +264 @@
 
 
-int task_set_retval(ipc_call_t *call)
+int task_set_retval(task_id_t sender, int retval, bool wait_for_exit)
 {
         int rc = EOK;
-        task_id_t id = call->in_task_id;
         
         fibril_rwlock_write_lock(&task_hash_table_lock);
-        task_t *t = task_get_by_id(id);
+        task_t *t = task_get_by_id(sender);
 
         if ((t == NULL) || (t->exit != TASK_EXIT_RUNNING)) {
@@ -277 +276 @@
         }
         
-        t->retval = IPC_GET_ARG1(*call);
-        t->retval_type = IPC_GET_ARG2(*call) ? RVAL_SET_EXIT : RVAL_SET;
+        t->retval = retval;
+        t->retval_type = wait_for_exit ? RVAL_SET_EXIT : RVAL_SET;
         
         event_notify(t);