Changeset 780c8ce in mainline for uspace/srv/taskman/main.c

Timestamp:

2019-08-07T05:52:27Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

012dd8e

Parents:

2aaccd3

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-10-22 23:09:22)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 05:52:27)

Message:

taskman: Light streamlining (removing TODOs)

• Low work attitude today

File:

• uspace/srv/taskman/main.c (modified) (5 diffs)

uspace/srv/taskman/main.c

@@ -27 +27 @@
  */
 
+/**
+ * Locking order:
+ * - task_hash_table_lock (task.c),
+ * - pending_wait_lock (event.c),
+ * - listeners_lock (event.c).
+ *
+ * @addtogroup taskman
+ * @{
+ */
+
 #include <adt/prodcons.h>
 #include <assert.h>
@@ -113 +123 @@
             MERGE_LOUP32(IPC_GET_ARG1(*icall), IPC_GET_ARG2(*icall));
         int flags = IPC_GET_ARG3(*icall);
-
-        wait_for_task(id, flags, iid, icall);
+        task_id_t waiter_id = icall->in_task_id;
+
+        wait_for_task(id, flags, iid, waiter_id);
 }
 
@@ -120 +131 @@
 {
         printf("%s:%i from %llu\n", __func__, __LINE__, icall->in_task_id);
-        int rc = task_set_retval(icall);
+        task_id_t sender = icall->in_task_id;
+        int retval = IPC_GET_ARG1(*icall);
+        bool wait_for_exit = IPC_GET_ARG2(*icall);
+
+        int rc = task_set_retval(sender, retval, wait_for_exit);
         async_answer_0(iid, rc);
 }
@@ -265 +280 @@
 }
 
-/** Build hard coded configuration */
-
 
 int main(int argc, char *argv[])
@@ -313 +326 @@
         return 0;
 }
+
+/**
+ * @}
+ */