Changeset 78192cc7 in mainline for uspace/srv/net/tcp/tqueue.c

Timestamp:

2014-07-13T14:06:23Z (10 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

af2a76c, f303f2cf

Parents:

c1b979a

Message:

Fibril timer locking improvements.

File:

• uspace/srv/net/tcp/tqueue.c (modified) (9 diffs)

uspace/srv/net/tcp/tqueue.c

@@ -59 +59 @@
 static void tcp_tqueue_timer_clear(tcp_conn_t *conn);
 
+#include <stdio.h>
 int tcp_tqueue_init(tcp_tqueue_t *tqueue, tcp_conn_t *conn)
 {
+        printf("tcp_tqueue_init\n");
         tqueue->conn = conn;
-        tqueue->timer = fibril_timer_create();
+        tqueue->timer = fibril_timer_create(&conn->lock);
         if (tqueue->timer == NULL)
                 return ENOMEM;
@@ -78 +80 @@
 void tcp_tqueue_fini(tcp_tqueue_t *tqueue)
 {
+        printf("tcp_tqueue_fini\n");
         if (tqueue->timer != NULL) {
                 fibril_timer_destroy(tqueue->timer);
@@ -319 +322 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: retransmit_timeout_func(%p)", conn->name, conn);
 
-        fibril_mutex_lock(&conn->lock);
+        tcp_conn_lock(conn);
 
         if (conn->cstate == st_closed) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "Connection already closed.");
-                fibril_mutex_unlock(&conn->lock);
+                tcp_conn_unlock(conn);
                 tcp_conn_delref(conn);
                 return;
@@ -331 +334 @@
         if (link == NULL) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "Nothing to retransmit");
-                fibril_mutex_unlock(&conn->lock);
+                tcp_conn_unlock(conn);
                 tcp_conn_delref(conn);
                 return;
@@ -341 +344 @@
         if (rt_seg == NULL) {
                 log_msg(LOG_DEFAULT, LVL_ERROR, "Memory allocation failed.");
-                fibril_mutex_unlock(&conn->lock);
+                tcp_conn_unlock(conn);
                 tcp_conn_delref(conn);
                 /* XXX Handle properly */
@@ -353 +356 @@
         tcp_tqueue_timer_set(tqe->conn);
 
-        fibril_mutex_unlock(&conn->lock);
+        tcp_conn_unlock(conn);
         tcp_conn_delref(conn);
+
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: retransmit_timeout_func(%p) end", conn->name, conn);
 }
 
@@ -360 +365 @@
 static void tcp_tqueue_timer_set(tcp_conn_t *conn)
 {
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: tcp_tqueue_timer_set()", conn->name);
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: tcp_tqueue_timer_set() begin", conn->name);
 
         /* Clear first to make sure we update refcnt correctly */
@@ -366 +371 @@
 
         tcp_conn_addref(conn);
-        fibril_timer_set(conn->retransmit.timer, RETRANSMIT_TIMEOUT,
+        fibril_timer_set_locked(conn->retransmit.timer, RETRANSMIT_TIMEOUT,
             retransmit_timeout_func, (void *) conn);
+
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: tcp_tqueue_timer_set() end", conn->name);
 }
 
@@ -373 +380 @@
 static void tcp_tqueue_timer_clear(tcp_conn_t *conn)
 {
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: tcp_tqueue_timer_clear()", conn->name);
-
-        if (fibril_timer_clear(conn->retransmit.timer) == fts_active)
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: tcp_tqueue_timer_clear() begin", conn->name);
+
+        if (fibril_timer_clear_locked(conn->retransmit.timer) == fts_active)
                 tcp_conn_delref(conn);
+
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "### %s: tcp_tqueue_timer_clear() end", conn->name);
 }