Changeset 7acd787 in mainline

Timestamp:

2019-01-03T00:53:50Z (6 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b9f1585, c477c80

Parents:

ca645a2

git-author:

Jiri Svoboda <jiri@…> (2019-01-03 00:48:00)

git-committer:

Jiri Svoboda <jiri@…> (2019-01-03 00:53:50)

Message:

Utility for listing PCI devices

Currently all information presented can also be gathered from devctl -v,
although 'pci' prints it in a nice compact format. Ability to print
more information, including information not available from devctl,
can be added later.

Files:

• .gitignore (modified) (1 diff)
• abi/include/abi/ipc/interfaces.h (modified) (1 diff)
• boot/Makefile.common (modified) (1 diff)
• uspace/Makefile (modified) (1 diff)
• uspace/app/pci/Makefile (added)
• uspace/app/pci/doc/doxygroups.h (added)
• uspace/app/pci/pci.c (added)
• uspace/drv/bus/pci/pciintel/Makefile (modified) (1 diff)
• uspace/drv/bus/pci/pciintel/ctl.c (added)
• uspace/drv/bus/pci/pciintel/ctl.h (added)
• uspace/drv/bus/pci/pciintel/pci.c (modified) (8 diffs)
• uspace/drv/bus/pci/pciintel/pci.h (modified) (4 diffs)
• uspace/lib/c/Makefile (modified) (1 diff)
• uspace/lib/c/generic/pci.c (added)
• uspace/lib/c/include/ipc/pci.h (added)
• uspace/lib/c/include/pci.h (added)
• uspace/lib/c/include/types/pci.h (added)
• uspace/srv/locsrv/locsrv.c (modified) (1 diff)

.gitignore

@@ -130 +130 @@
 uspace/app/nic/nic
 uspace/app/nterm/nterm
+uspace/app/pci/pci
 uspace/app/perf/perf
 uspace/app/ping/ping

abi/include/abi/ipc/interfaces.h

@@ -183 +183 @@
             FOURCC_COMPACT('v', 'b', 'd', ' ') | IFACE_EXCHANGE_SERIALIZE,
         INTERFACE_IPC_TEST =
-            FOURCC_COMPACT('i', 'p', 'c', 't') | IFACE_EXCHANGE_SERIALIZE
+            FOURCC_COMPACT('i', 'p', 'c', 't') | IFACE_EXCHANGE_SERIALIZE,
+        INTERFACE_PCI =
+            FOURCC_COMPACT('p', 'c', 'i', ' ') | IFACE_EXCHANGE_SERIALIZE
 } iface_t;
 

boot/Makefile.common

@@ -206 +206 @@
         netecho \
         nterm \
+        pci \
         ping \
         pkg \

uspace/Makefile

@@ -67 +67 @@
         app/netecho \
         app/nterm \
+        app/pci \
         app/perf \
         app/redir \

uspace/drv/bus/pci/pciintel/Makefile

@@ -32 +32 @@
 
 SOURCES = \
+        ctl.c \
         pci.c
 

uspace/drv/bus/pci/pciintel/pci.c

@@ -1 +1 @@
 /*
+ * Copyright (c) 2019 Jiri Svoboda
  * Copyright (c) 2010 Lenka Trochtova
- * Copyright (c) 2018 Jiri Svoboda
  * All rights reserved.
  *
@@ -58 +58 @@
 #include <pci_dev_iface.h>
 
+#include "ctl.h"
 #include "pci.h"
+#include "pci_regs.h"
 
 #define NAME "pciintel"
@@ -73 +75 @@
 
 /** Obtain PCI bus soft-state from DDF device node */
-#if 0
-static pci_bus_t *pci_bus(ddf_dev_t *dnode)
+pci_bus_t *pci_bus(ddf_dev_t *dnode)
 {
         return ddf_dev_data_get(dnode);
 }
-#endif
 
 /** Obtain PCI bus soft-state from function soft-state */
@@ -448 +448 @@
 
         /* TODO add subsys ids, but those exist only in header type 0 */
+}
+
+/** Get first PCI function.
+ *
+ * @param bus PCI bus
+ * @return First PCI function on @a bus or @c NULL if there is none
+ */
+pci_fun_t *pci_fun_first(pci_bus_t *bus)
+{
+        link_t *link;
+
+        link = list_first(&bus->funs);
+        if (link == NULL)
+                return NULL;
+
+        return list_get_instance(link, pci_fun_t, lfuns);
+}
+
+/** Get next PCI function.
+ *
+ * @param cur Current function
+ * @return Next PCI function on the same bus or @c NULL if there is none
+ */
+pci_fun_t *pci_fun_next(pci_fun_t *cur)
+{
+        link_t *link;
+
+        link = list_next(&cur->lfuns, &cur->busptr->funs);
+        if (link == NULL)
+                return NULL;
+
+        return list_get_instance(link, pci_fun_t, lfuns);
 }
 
@@ -691 +723 @@
                                 continue;
                         }
+
+                        list_append(&fun->lfuns, &bus->funs);
                 }
         }
@@ -718 +752 @@
                 goto fail;
         }
+
+        list_initialize(&bus->funs);
         fibril_mutex_initialize(&bus->conf_mutex);
 
@@ -802 +838 @@
         }
 
+        ddf_fun_set_conn_handler(ctl, pci_ctl_connection);
+
         /* Enumerate functions. */
         ddf_msg(LVL_DEBUG, "Enumerating the bus");
@@ -816 +854 @@
         }
 
+        rc = ddf_fun_add_to_category(ctl, "pci");
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Failed adding control function to category "
+                    "'pci'.");
+                goto fail;
+        }
+
         hw_res_clean_resource_list(&hw_resources);
 

uspace/drv/bus/pci/pciintel/pci.h

@@ -37 +37 @@
 #define PCI_H_
 
+#include <adt/list.h>
+#include <ddi.h>
 #include <ddf/driver.h>
-#include "pci_regs.h"
+#include <fibril_synch.h>
 
 #define PCI_MAX_HW_RES 10
@@ -50 +52 @@
         pio_window_t pio_win;
         fibril_mutex_t conf_mutex;
+        /** List of functions (of pci_fun_t) */
+        list_t funs;
 } pci_bus_t;
 
@@ -55 +59 @@
         pci_bus_t *busptr;
         ddf_fun_t *fnode;
+        /** Link to @c busptr->funs */
+        link_t lfuns;
 
         int bus;
@@ -71 +77 @@
 } pci_fun_t;
 
+extern pci_bus_t *pci_bus(ddf_dev_t *);
+
 extern void pci_fun_create_match_ids(pci_fun_t *);
+extern pci_fun_t *pci_fun_first(pci_bus_t *);
+extern pci_fun_t *pci_fun_next(pci_fun_t *);
 
 extern uint8_t pci_conf_read_8(pci_fun_t *, int);

uspace/lib/c/Makefile

@@ -165 +165 @@
         generic/assert.c \
         generic/bsearch.c \
+        generic/pci.c \
         generic/pio_trace.c \
         generic/qsort.c \

uspace/srv/locsrv/locsrv.c

@@ -1390 +1390 @@
         categ_dir_add_cat(&cdir, cat);
 
+        cat = category_new("pci");
+        categ_dir_add_cat(&cdir, cat);
+
         return true;
 }