Changeset 7d07bf3 in mainline

Timestamp:

2007-01-29T18:39:27Z (18 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

623b49f1

Parents:

b1349e0

Message:

signed/unsigned comparison, explicit typecast

Location:

kernel

Files:

• arch/amd64/src/debugger.c (modified) (1 diff)
• arch/ia32/src/mm/tlb.c (modified) (1 diff)
• genarch/src/acpi/acpi.c (modified) (5 diffs)

kernel/arch/amd64/src/debugger.c

@@ -249 +249 @@
         printf("***Type 'exit' to exit kconsole.\n");
         atomic_set(&haltstate,1);
-        kconsole("debug");
+        kconsole((void *) "debug");
         atomic_set(&haltstate,0);
 }

kernel/arch/ia32/src/mm/tlb.c

@@ -62 +62 @@
 void tlb_invalidate_pages(asid_t asid, uintptr_t page, count_t cnt)
 {
-        int i;
+        unsigned int i;
 
         for (i = 0; i < cnt; i++)

kernel/genarch/src/acpi/acpi.c

@@ -57 +57 @@
         struct acpi_rsdp *r = (struct acpi_rsdp *) rsdp;
         uint8_t sum = 0;
-        int i;
+        unsigned int i;
         
-        for (i=0; i<20; i++)
+        for (i = 0; i < 20; i++)
                 sum += rsdp[i];
                 
@@ -68 +68 @@
                 return 1; /* ACPI 1.0 */
                 
-        for (; i<r->length; i++)
+        for (; i < r->length; i++)
                 sum += rsdp[i];
                 
@@ -79 +79 @@
         struct acpi_sdt_header *h = (struct acpi_sdt_header *) sdt;
         uint8_t sum = 0;
-        int i;
+        unsigned int i;
 
-        for (i=0; i<h->length; i++)
+        for (i = 0; i < h->length; i++)
                 sum += sdt[i];
                 
@@ -95 +95 @@
 static void configure_via_rsdt(void)
 {
-        int i, j, cnt = (acpi_rsdt->header.length - sizeof(struct acpi_sdt_header))/sizeof(uint32_t);
+        unsigned int i, j, cnt = (acpi_rsdt->header.length - sizeof(struct acpi_sdt_header)) / sizeof(uint32_t);
         
-        for (i=0; i<cnt; i++) {
-                for (j=0; j<sizeof(signature_map)/sizeof(struct acpi_signature_map); j++) {
+        for (i = 0; i < cnt; i++) {
+                for (j = 0; j < sizeof(signature_map) / sizeof(struct acpi_signature_map); j++) {
                         struct acpi_sdt_header *h = (struct acpi_sdt_header *) (unative_t) acpi_rsdt->entry[i];
                 
                         map_sdt(h);     
-                        if (*((uint32_t *) &h->signature[0])==*((uint32_t *) &signature_map[j].signature[0])) {
+                        if (*((uint32_t *) &h->signature[0]) == *((uint32_t *) &signature_map[j].signature[0])) {
                                 if (!acpi_sdt_check((uint8_t *) h))
                                         goto next;
@@ -116 +116 @@
 static void configure_via_xsdt(void)
 {
-        int i, j, cnt = (acpi_xsdt->header.length - sizeof(struct acpi_sdt_header))/sizeof(uint64_t);
+        unsigned int i, j, cnt = (acpi_xsdt->header.length - sizeof(struct acpi_sdt_header)) / sizeof(uint64_t);
         
-        for (i=0; i<cnt; i++) {
-                for (j=0; j<sizeof(signature_map)/sizeof(struct acpi_signature_map); j++) {
+        for (i = 0; i < cnt; i++) {
+                for (j = 0; j < sizeof(signature_map) / sizeof(struct acpi_signature_map); j++) {
                         struct acpi_sdt_header *h = (struct acpi_sdt_header *) ((uintptr_t) acpi_rsdt->entry[i]);
 
                         map_sdt(h);
-                        if (*((uint32_t *) &h->signature[0])==*((uint32_t *) &signature_map[j].signature[0])) {
+                        if (*((uint32_t *) &h->signature[0]) == *((uint32_t *) &signature_map[j].signature[0])) {
                                 if (!acpi_sdt_check((uint8_t *) h))
                                         goto next;