Changeset 7d5287db in mainline

Timestamp:

2018-01-25T18:55:18Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e454d9c

Parents:

d08aa42d

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-25 18:55:01)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-25 18:55:18)

Message:

xhci: fix forgotten transfer when EP 0 is gone

File:

• uspace/drv/bus/usb/xhci/transfers.c (modified) (1 diff)

uspace/drv/bus/usb/xhci/transfers.c

@@ -468 +468 @@
                                  * possible that we have to clear all of them.
                                  */
-                                xhci_endpoint_clear_halt(xhci_endpoint_get(halted_ep), 0);
+                                const int err = xhci_endpoint_clear_halt(xhci_endpoint_get(halted_ep), 0);
                                 endpoint_del_ref(halted_ep);
+                                if (err) {
+                                        /*
+                                         * The endpoint halt condition failed to be cleared in HC.
+                                         * As it does not make sense to send the reset to the device
+                                         * itself, return as unschedulable answer.
+                                         *
+                                         * Furthermore, if this is a request to clear EP 0 stall, it
+                                         * would be gone forever, as the endpoint is halted.
+                                         */
+                                        return err;
+                                }
                         } else {
                                 usb_log_warning("Device(%u): Resetting unregistered endpoint"