Changes in uspace/drv/bus/usb/uhci/hc.c [1ae74c6:7de1988c] in mainline

File:

• uspace/drv/bus/usb/uhci/hc.c (modified) (7 diffs)

uspace/drv/bus/usb/uhci/hc.c

@@ -90 +90 @@
 static int hc_debug_checker(void *arg);
 
-
-/** Get number of PIO ranges used in IRQ code.
- * @return Number of ranges.
- */
-size_t hc_irq_pio_range_count(void)
-{
-        return sizeof(uhci_irq_pio_ranges) / sizeof(irq_pio_range_t);
-}
-
-/** Get number of commands used in IRQ code.
- * @return Number of commands.
- */
-size_t hc_irq_cmd_count(void)
-{
-        return sizeof(uhci_irq_commands) / sizeof(irq_cmd_t);
-}
+enum {
+        /** Number of PIO ranges used in IRQ code */
+        hc_irq_pio_range_count =
+            sizeof(uhci_irq_pio_ranges) / sizeof(irq_pio_range_t),
+
+        /* Number of commands used in IRQ code */
+        hc_irq_cmd_count =
+            sizeof(uhci_irq_commands) / sizeof(irq_cmd_t)
+};
 
 /** Generate IRQ code.
@@ -112 +105 @@
  * @param[out] cmds Commands buffer.
  * @param[in] cmds_size Size of the commands buffer (bytes).
- * @param[in] regs Physical address of device's registers.
- * @param[in] reg_size Size of the register area (bytes).
+ * @param[in] regs Device's register range.
  *
  * @return Error code.
@@ -119 +111 @@
 int
 hc_get_irq_code(irq_pio_range_t ranges[], size_t ranges_size, irq_cmd_t cmds[],
-    size_t cmds_size, uintptr_t regs, size_t reg_size)
+    size_t cmds_size, addr_range_t *regs)
 {
         if ((ranges_size < sizeof(uhci_irq_pio_ranges)) ||
             (cmds_size < sizeof(uhci_irq_commands)) ||
-            (reg_size < sizeof(uhci_regs_t)))
+            (RNGSZ(*regs) < sizeof(uhci_regs_t)))
                 return EOVERFLOW;
 
         memcpy(ranges, uhci_irq_pio_ranges, sizeof(uhci_irq_pio_ranges));
-        ranges[0].base = regs;
+        ranges[0].base = RNGABS(*regs);
 
         memcpy(cmds, uhci_irq_commands, sizeof(uhci_irq_commands));
-        uhci_regs_t *registers = (uhci_regs_t *) regs;
+        uhci_regs_t *registers = (uhci_regs_t *) RNGABSPTR(*regs);
         cmds[0].addr = &registers->usbsts;
         cmds[3].addr = &registers->usbsts;
+
+        return EOK;
+}
+
+/** Register interrupt handler.
+ *
+ * @param[in] device Host controller DDF device
+ * @param[in] regs Register range
+ * @param[in] irq Interrupt number
+ * @paran[in] handler Interrupt handler
+ *
+ * @return EOK on success or negative error code
+ */
+int hc_register_irq_handler(ddf_dev_t *device, addr_range_t *regs, int irq,
+    interrupt_handler_t handler)
+{
+        int rc;
+        irq_pio_range_t irq_ranges[hc_irq_pio_range_count];
+        irq_cmd_t irq_cmds[hc_irq_cmd_count];
+        rc = hc_get_irq_code(irq_ranges, sizeof(irq_ranges), irq_cmds,
+            sizeof(irq_cmds), regs);
+        if (rc != EOK) {
+                usb_log_error("Failed to generate IRQ commands: %s.\n",
+                    str_error(rc));
+                return rc;
+        }
+
+        irq_code_t irq_code = {
+                .rangecount = hc_irq_pio_range_count,
+                .ranges = irq_ranges,
+                .cmdcount = hc_irq_cmd_count,
+                .cmds = irq_cmds
+        };
+
+        /* Register handler to avoid interrupt lockup */
+        rc = register_interrupt_handler(device, irq, handler, &irq_code);
+        if (rc != EOK) {
+                usb_log_error("Failed to register interrupt handler: %s.\n",
+                    str_error(rc));
+                return rc;
+        }
 
         return EOK;
@@ -197 +230 @@
  *
  * @param[in] instance Memory place to initialize.
- * @param[in] regs Address of I/O control registers.
- * @param[in] reg_size Size of I/O control registers.
+ * @param[in] regs Range of device's I/O control registers.
  * @param[in] interrupts True if hw interrupts should be used.
  * @return Error code.
@@ -206 +238 @@
  * interrupt fibrils.
  */
-int hc_init(hc_t *instance, void *regs, size_t reg_size, bool interrupts)
-{
-        assert(reg_size >= sizeof(uhci_regs_t));
-        int ret;
-
-#define CHECK_RET_RETURN(ret, message...) \
-        if (ret != EOK) { \
-                usb_log_error(message); \
-                return ret; \
-        } else (void) 0
+int hc_init(hc_t *instance, addr_range_t *regs, bool interrupts)
+{
+        assert(regs->size >= sizeof(uhci_regs_t));
+        int rc;
 
         instance->hw_interrupts = interrupts;
@@ -222 +248 @@
         /* allow access to hc control registers */
         uhci_regs_t *io;
-        ret = pio_enable(regs, reg_size, (void **)&io);
-        CHECK_RET_RETURN(ret, "Failed to gain access to registers at %p: %s.\n",
-            io, str_error(ret));
+        rc = pio_enable_range(regs, (void **) &io);
+        if (rc != EOK) {
+                usb_log_error("Failed to gain access to registers at %p: %s.\n",
+                    io, str_error(rc));
+                return rc;
+        }
+
         instance->registers = io;
         usb_log_debug(
-            "Device registers at %p (%zuB) accessible.\n", io, reg_size);
-
-        ret = hc_init_mem_structures(instance);
-        CHECK_RET_RETURN(ret,
-            "Failed to initialize UHCI memory structures: %s.\n",
-            str_error(ret));
-
-#undef CHECK_RET_RETURN
+            "Device registers at %p (%zuB) accessible.\n", io, regs->size);
+
+        rc = hc_init_mem_structures(instance);
+        if (rc != EOK) {
+                usb_log_error("Failed to initialize UHCI memory structures: %s.\n",
+                    str_error(rc));
+                return rc;
+        }
 
         hcd_init(&instance->generic, USB_SPEED_FULL,
@@ -397 +427 @@
 
         return EOK;
-#undef CHECK_RET_CLEAR_RETURN
 }