Changeset 7f880ee8 in mainline

Timestamp:

2008-06-03T19:22:59Z (17 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fadfaf8

Parents:

78d0da8

Message:

Return value argument to ipc_call_sync_X_Y() may not be int or it will
break on 64-machines that are sensitive to unaligned memory accesses.
Moreover, overcasting int * to sysarg_t * is not a good idea either
even if the int is by chance aligned on a 64-bit boundary as some
unknown memory will get overwritten during the assignment. Change the
type of the retval argument to ipcarg_t.

File:

• uspace/srv/fs/tmpfs/tmpfs_ops.c (modified) (1 diff)

uspace/srv/fs/tmpfs/tmpfs_ops.c

@@ -273 +273 @@
                 
                 if (*bufpos == *buflen) {
-                        int retval;
-                        int rc = ipc_call_sync_2_1(phone, RD_READ_BLOCK, *pos / BLOCK_SIZE, BLOCK_SIZE, (sysarg_t *) &retval);
+                        ipcarg_t retval;
+                        int rc = ipc_call_sync_2_1(phone, RD_READ_BLOCK,
+                            *pos / BLOCK_SIZE, BLOCK_SIZE,
+                            &retval);
                         if ((rc != EOK) || (retval != EOK))
                                 return false;