Changeset 7faabb7 in mainline for kernel/generic/src/proc/thread.c

Timestamp:

2008-11-07T23:16:28Z (16 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

24345a5

Parents:

86e3d62

Message:

Fix sys_thread_create(): could fail when passed name was at end of mapping, could crash if provided name was not null-terminated.

File:

• kernel/generic/src/proc/thread.c (modified) (2 diffs)

kernel/generic/src/proc/thread.c

@@ -709 +709 @@
  */
 unative_t sys_thread_create(uspace_arg_t *uspace_uarg, char *uspace_name,
-    thread_id_t *uspace_thread_id)
+    size_t name_len, thread_id_t *uspace_thread_id)
 {
         thread_t *t;
@@ -716 +716 @@
         int rc;
 
-        rc = copy_from_uspace(namebuf, uspace_name, THREAD_NAME_BUFLEN);
+        if (name_len >= THREAD_NAME_BUFLEN)
+                name_len = THREAD_NAME_BUFLEN - 1;
+
+        rc = copy_from_uspace(namebuf, uspace_name, name_len);
         if (rc != 0)
                 return (unative_t) rc;
+
+        namebuf[name_len] = '\0';
 
         /*