Changeset 832cbe7 in mainline for uspace/drv/block/pci-ide/main.c

Timestamp:

2025-02-05T12:30:20Z (7 days ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master

Children:

accdf882

Parents:

0dab4850

git-author:

Jiri Svoboda <jiri@…> (2025-02-04 21:30:06)

git-committer:

Jiri Svoboda <jiri@…> (2025-02-05 12:30:20)

Message:

Add proper IDE PCI to ISA fallback mechanism.

To determine if legacy IDE I/O ports are free, isa-ide asks isa,
who asks pciintel. pciintel waits for bus enumeration to complete,
then waits for all functions except the one who is asking
(which is ISA bus) to stabilize. During attach pci-ide will claim
the legacy IDE ports. Thus, if at this point legacy IDE ports
are unclaimed, pciintel tells ISA they are free, which tells isa-ide,
which continues to attach. If they are not free, isa-ide will not
attach.

This works for all use cases, including system without PCI bus,
system with PCI bus, but no (or disabled) PCI IDE, system with PCI
IDE with unrecognized VID/PID (which we will handle in legacy ISA mode).

File:

• uspace/drv/block/pci-ide/main.c (modified) (3 diffs)

uspace/drv/block/pci-ide/main.c

@@ -1 +1 @@
 /*
- * Copyright (c) 2024 Jiri Svoboda
+ * Copyright (c) 2025 Jiri Svoboda
  * All rights reserved.
  *
@@ -133 +133 @@
         pci_ide_ctrl_t *ctrl;
         pci_ide_hwres_t res;
+        async_sess_t *parent_sess;
         errno_t rc;
 
@@ -164 +165 @@
         if (rc != EOK) {
                 ddf_msg(LVL_ERROR, "Failed initializing ATA controller.");
+                rc = EIO;
+                goto error;
+        }
+
+        parent_sess = ddf_dev_parent_sess_get(dev);
+        if (parent_sess == NULL) {
+                rc = ENOMEM;
+                goto error;
+        }
+
+        /* Claim legacy I/O range to prevent ISA IDE from attaching there. */
+        rc = hw_res_claim_legacy_io(parent_sess, hwc_isa_ide);
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Failed claiming legacy I/O range.");
                 rc = EIO;
                 goto error;