Changeset 8498915 in mainline for kernel/generic/src/ipc/sysipc.c

Timestamp:

2007-11-22T09:09:04Z (17 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0cc4313

Parents:

b74959bd

Message:

Be more deterministic when a user accidently uses fast version of IPC
call/answer instead of the full one and passes fewer arguments than required by
the recipient of the call/response.

and the recipient interprets arguments that
were actually not passed by the sender.

File:

• kernel/generic/src/ipc/sysipc.c (modified) (3 diffs)

kernel/generic/src/ipc/sysipc.c

@@ -378 +378 @@
         IPC_SET_ARG2(call.data, arg2);
         IPC_SET_ARG3(call.data, arg3);
+        /*
+         * To achieve deterministic behavior, zero out arguments that are beyond
+         * the limits of the fast version.
+         */
+        IPC_SET_ARG4(call.data, 0);
+        IPC_SET_ARG5(call.data, 0);
 
         if (!(res = request_preprocess(&call))) {
@@ -478 +484 @@
         IPC_SET_ARG3(call->data, arg3);
         IPC_SET_ARG4(call->data, arg4);
+        /*
+         * To achieve deterministic behavior, zero out arguments that are beyond
+         * the limits of the fast version.
+         */
+        IPC_SET_ARG5(call->data, 0);
 
         if (!(res = request_preprocess(call)))
@@ -624 +635 @@
         IPC_SET_ARG3(call->data, arg3);
         IPC_SET_ARG4(call->data, arg4);
+        /*
+         * To achieve deterministic behavior, zero out arguments that are beyond
+         * the limits of the fast version.
+         */
+        IPC_SET_ARG5(call->data, 0);
         rc = answer_preprocess(call, saveddata ? &saved_data : NULL);