Changeset 87337dc5 in mainline for uspace/lib/c/generic/uuid.c

Timestamp:

2018-07-09T15:00:24Z (6 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d054ad3

Parents:

914c693

git-author:

Jiri Svoboda <jiri@…> (2018-07-08 19:58:56)

git-committer:

Jiri Svoboda <jiri@…> (2018-07-09 15:00:24)

Message:

Random number generator interface. FAT and exFAT should be created with random volume serial numbers.

File:

• uspace/lib/c/generic/uuid.c (modified) (3 diffs)

uspace/lib/c/generic/uuid.c

@@ -35 +35 @@
 #include <errno.h>
 #include <uuid.h>
+#include <rndgen.h>
 #include <stdlib.h>
 #include <stddef.h>
-#include <time.h>
 #include <str.h>
 
@@ -48 +48 @@
 {
         int i;
-        struct timeval tv;
+        rndgen_t *rndgen;
+        errno_t rc;
 
-        /* XXX This is a rather poor way of generating random numbers */
-        gettimeofday(&tv, NULL);
-        srand(tv.tv_sec ^ tv.tv_usec);
+        rc = rndgen_create(&rndgen);
+        if (rc != EOK)
+                return EIO;
 
-        for (i = 0; i < uuid_bytes; i++)
-                uuid->b[i] = rand();
+        for (i = 0; i < uuid_bytes; i++) {
+                rc = rndgen_uint8(rndgen, &uuid->b[i]);
+                if (rc != EOK) {
+                        rc = EIO;
+                        goto error;
+                }
+        }
 
         /* Version 4 UUID from random or pseudo-random numbers */
@@ -62 +68 @@
 
         return EOK;
+error:
+        rndgen_destroy(rndgen);
+        return rc;
 }