Changeset 88169d9 in mainline

Timestamp:

2006-06-07T00:34:09Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

977649b

Parents:

590cb380

Message:

Move comment.

Do TLB shootdown also when allocating new ASID.

Files:

• genarch/src/mm/asid.c (modified) (2 diffs)
• generic/src/proc/task.c (modified) (2 diffs)
• generic/src/proc/thread.c (modified) (2 diffs)

genarch/src/mm/asid.c

@@ -125 +125 @@
                  */
                 tlb_shootdown_start(TLB_INVL_ASID, asid, 0, 0);
+                tlb_invalidate_asid(asid);
                 tlb_shootdown_finalize();
-                tlb_invalidate_asid(asid);
         } else {
 
@@ -136 +136 @@
                 asid = asid_find_free();
                 asids_allocated++;
+
+                /*
+                 * Purge the allocated rid from TLBs.
+                 */
+                tlb_shootdown_start(TLB_INVL_ASID, asid, 0, 0);
+                tlb_invalidate_asid(asid);
+                tlb_shootdown_finalize();
         }
         

generic/src/proc/task.c

@@ -56 +56 @@
 #endif
 
+/** Spinlock protecting the tasks_btree B+tree. */
 SPINLOCK_INITIALIZE(tasks_lock);
+
+/** B+tree of active tasks.
+ *
+ * The task is guaranteed to exist after it was found in the tasks_btree as long as:
+ * @li the tasks_lock is held,
+ * @li the task's lock is held when task's lock is acquired before releasing tasks_lock or
+ * @li the task's refcount is grater than 0
+ *
+ */
 btree_t tasks_btree;
+
 static task_id_t task_counter = 0;
 
@@ -239 +250 @@
  * The tasks_lock must be already held by the caller of this function
  * and interrupts must be disabled.
- *
- * The task is guaranteed to exist after it was found in the tasks_btree as long as:
- * @li the tasks_lock is held,
- * @li the task's lock is held when task's lock is acquired before releasing tasks_lock or
- * @li the task's refcount is grater than 0
  *
  * @param id Task ID.

generic/src/proc/thread.c

@@ -76 +76 @@
 }; 
 
-/** Lock protecting threads_head list. For locking rules, see declaration thereof. */
+/** Lock protecting the threads_btree B+tree. For locking rules, see declaration thereof. */
 SPINLOCK_INITIALIZE(threads_lock);
-btree_t threads_btree;                  /**< B+tree of all threads. */
+
+/** B+tree of all threads.
+ *
+ * When a thread is found in the threads_btree B+tree, it is guaranteed to exist as long
+ * as the threads_lock is held.
+ */
+btree_t threads_btree;          
 
 SPINLOCK_INITIALIZE(tidlock);
@@ -553 +559 @@
  * interrupts must be already disabled.
  *
- * When a thread is found in threads_btree, it is guaranteed to exist as long
- * as the threads_lock is held.
- *
  * @param t Pointer to thread.
  *