Changeset 8ee620c in mainline

Timestamp:

2018-08-03T16:56:31Z (6 years ago)

Author:

Jiří Zárevúcky <jiri.zarevucky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

158da11

Parents:

02246b8

git-author:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-08-03 16:36:29)

git-committer:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-08-03 16:56:31)

Message:

Overlap in memcpy().

File:

• uspace/lib/crypto/aes.c (modified) (2 diffs)

uspace/lib/crypto/aes.c

@@ -249 +249 @@
         for (size_t i = 1; i < ELEMS; i++) {
                 memcpy(temp, state[i], i);
-                memcpy(state[i], state[i] + i, ELEMS - i);
+                memmove(state[i], state[i] + i, ELEMS - i);
                 memcpy(state[i] + ELEMS - i, temp, i);
         }
@@ -265 +265 @@
         for (size_t i = 1; i < ELEMS; i++) {
                 memcpy(temp, state[i], ELEMS - i);
-                memcpy(state[i], state[i] + ELEMS - i, i);
+                memmove(state[i], state[i] + ELEMS - i, i);
                 memcpy(state[i] + i, temp, ELEMS - i);
         }