Changeset 8f4f444 in mainline

Timestamp:

2012-07-26T21:38:14Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4fc93d5

Parents:

f66c203d

Message:

Add a variant of fault_if_from_uspace() that doesn't check whether
the istate is from uspace.

Location:

kernel/generic

Files:

• include/interrupt.h (modified) (2 diffs)
• src/interrupt/interrupt.c (modified) (3 diffs)

kernel/generic/include/interrupt.h

@@ -38 +38 @@
 #include <arch/interrupt.h>
 #include <print.h>
+#include <stdarg.h>
 #include <typedefs.h>
 #include <proc/task.h>
@@ -58 +59 @@
 extern exc_table_t exc_table[];
 
+extern void fault_from_uspace(istate_t *, const char *, ...);
 extern void fault_if_from_uspace(istate_t *, const char *, ...)
     PRINTF_ATTRIBUTE(2, 3);

kernel/generic/src/interrupt/interrupt.c

@@ -50 +50 @@
 #include <panic.h>
 #include <print.h>
+#include <stdarg.h>
 #include <symtab.h>
 #include <proc/thread.h>
@@ -165 +166 @@
 }
 
-/** Terminate thread and task if exception came from userspace.
- *
- */
-NO_TRACE void fault_if_from_uspace(istate_t *istate, const char *fmt, ...)
-{
-        if (!istate_from_uspace(istate))
-                return;
-        
+static NO_TRACE void fault_from_uspace_core(istate_t *istate, const char *fmt, va_list args)
+{
         printf("Task %s (%" PRIu64 ") killed due to an exception at "
             "program counter %p.\n", TASK->name, TASK->taskid,
@@ -181 +176 @@
         
         printf("Kill message: ");
+        vprintf(fmt, args);
+        printf("\n");
+        
+        task_kill_self(true);
+}
+
+/** Terminate thread and task after the exception came from userspace.
+ *
+ */
+NO_TRACE void fault_from_uspace(istate_t *istate, const char *fmt, ...)
+{
+        va_list args;
+
+        va_start(args, fmt);
+        fault_from_uspace_core(istate, fmt, args);
+        va_end(args);
+}
+
+/** Terminate thread and task if exception came from userspace.
+ *
+ */
+NO_TRACE void fault_if_from_uspace(istate_t *istate, const char *fmt, ...)
+{
+        if (!istate_from_uspace(istate))
+                return;
         
         va_list args;
         va_start(args, fmt);
-        vprintf(fmt, args);
+        fault_from_uspace_core(istate, fmt, args);
         va_end(args);
-        printf("\n");
-        
-        task_kill_self(true);
 }