Changes in kernel/generic/src/proc/thread.c [df58e44:96b02eb9] in mainline

File:

• kernel/generic/src/proc/thread.c (modified) (8 diffs)

kernel/generic/src/proc/thread.c

@@ -239 +239 @@
  * Switch thread to the ready state.
  *
- * @param thread Thread to make ready.
+ * @param t Thread to make ready.
  *
  */
@@ -246 +246 @@
         irq_spinlock_lock(&thread->lock, true);
         
-        ASSERT(thread->state != Ready);
+        ASSERT(!(thread->state == Ready));
         
         int i = (thread->priority < RQ_COUNT - 1)
@@ -338 +338 @@
         
         thread->interrupted = false;
-        thread->btrace = false;
         thread->detached = false;
         waitq_initialize(&thread->join_wq);
@@ -536 +535 @@
 /** Detach thread.
  *
- * Mark the thread as detached. If the thread is already
- * in the Lingering state, deallocate its resources.
+ * Mark the thread as detached, if the thread is already in the Lingering
+ * state, deallocate its resources.
  *
  * @param thread Thread to be detached.
@@ -741 +740 @@
         ASSERT(interrupts_disabled());
         ASSERT(irq_spinlock_locked(&threads_lock));
-        
+
         thread_iterator_t iterator;
         
@@ -752 +751 @@
 }
 
-void thread_stack_trace(thread_id_t thread_id)
-{
-        irq_spinlock_lock(&threads_lock, true);
-        
-        thread_t *thread = thread_find_by_id(thread_id);
-        if (thread == NULL) {
-                printf("No such thread.\n");
-                irq_spinlock_unlock(&threads_lock, true);
-                return;
-        }
-        
-        irq_spinlock_lock(&thread->lock, false);
-        
-        /*
-         * Schedule a stack trace to be printed
-         * just before the thread is scheduled next.
-         *
-         * If the thread is sleeping then try to interrupt
-         * the sleep. Any request for printing an uspace stack
-         * trace from within the kernel should be always
-         * considered a last resort debugging means, therefore
-         * forcing the thread's sleep to be interrupted
-         * is probably justifiable.
-         */
-        
-        bool sleeping = false;
-        istate_t *istate = thread->udebug.uspace_state;
-        if (istate != NULL) {
-                printf("Scheduling thread stack trace.\n");
-                thread->btrace = true;
-                if (thread->state == Sleeping)
-                        sleeping = true;
-        } else
-                printf("Thread interrupt state not available.\n");
-        
-        irq_spinlock_unlock(&thread->lock, false);
-        
-        if (sleeping)
-                waitq_interrupt_sleep(thread);
-        
-        irq_spinlock_unlock(&threads_lock, true);
-}
 
 /** Process syscall to create new thread.
@@ -836 +793 @@
                                  * has already been created. We need to undo its
                                  * creation now.
+                                 *
                                  */
                                 
@@ -857 +815 @@
                  * THREAD_B events for threads that already existed
                  * and could be detected with THREAD_READ before.
+                 *
                  */
                 udebug_thread_b_event_attach(thread, TASK);