Changeset 984a9ba in mainline for uspace/drv/intctl/apic/apic.c

Timestamp:

2018-07-05T09:34:09Z (7 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63d46341

Parents:

76f566d

Message:

do not expose the call capability handler from the async framework

Keep the call capability handler encapsulated within the async framework
and do not expose it explicitly via its API. Use the pointer to
ipc_call_t as the sole object identifying an IPC call in the code that
uses the async framework.

This plugs a major leak in the abstraction and also simplifies both the
async framework (slightly) and all IPC servers.

File:

• uspace/drv/intctl/apic/apic.c (modified) (3 diffs)

uspace/drv/intctl/apic/apic.c

@@ -160 +160 @@
 /** Handle one connection to APIC.
  *
- * @param iid   Hash of the request that opened the connection.
  * @param icall Call data of the request that opened the connection.
- * @param arg   Local argument.
- */
-static void apic_connection(cap_call_handle_t icall_handle, ipc_call_t *icall, void *arg)
-{
-        cap_call_handle_t chandle;
+ * @param arg   Local argument.
+ *
+ */
+static void apic_connection(ipc_call_t *icall, void *arg)
+{
         ipc_call_t call;
         apic_t *apic;
@@ -173 +172 @@
          * Answer the first IPC_M_CONNECT_ME_TO call.
          */
-        async_answer_0(icall_handle, EOK);
-
-        apic = (apic_t *)ddf_dev_data_get(ddf_fun_get_dev((ddf_fun_t *)arg));
+        async_answer_0(icall, EOK);
+
+        apic = (apic_t *) ddf_dev_data_get(ddf_fun_get_dev((ddf_fun_t *) arg));
 
         while (true) {
-                chandle = async_get_call(&call);
+                async_get_call(&call);
 
                 if (!IPC_GET_IMETHOD(call)) {
                         /* The other side has hung up. */
-                        async_answer_0(chandle, EOK);
+                        async_answer_0(&call, EOK);
                         return;
                 }
@@ -188 +187 @@
                 switch (IPC_GET_IMETHOD(call)) {
                 case IRC_ENABLE_INTERRUPT:
-                        async_answer_0(chandle, apic_enable_irq(apic,
+                        async_answer_0(&call, apic_enable_irq(apic,
                             IPC_GET_ARG1(call)));
                         break;
                 case IRC_DISABLE_INTERRUPT:
                         /* XXX TODO */
-                        async_answer_0(chandle, EOK);
+                        async_answer_0(&call, EOK);
                         break;
                 case IRC_CLEAR_INTERRUPT:
                         /* Noop */
-                        async_answer_0(chandle, EOK);
+                        async_answer_0(&call, EOK);
                         break;
                 default:
-                        async_answer_0(chandle, EINVAL);
+                        async_answer_0(&call, EINVAL);
                         break;
                 }