Changes in / [d600874:98e15b1] in mainline

Location:

uspace/lib/usbhid/src

Files:

• hiddescriptor.c (modified) (3 diffs)
• hidparser.c (modified) (9 diffs)

uspace/lib/usbhid/src/hiddescriptor.c

@@ -187 +187 @@
 
                 field = malloc(sizeof(usb_hid_report_field_t));
-                if(field == NULL) {
-                        return ENOMEM;
-                }
-
                 memset(field, 0, sizeof(usb_hid_report_field_t));
                 list_initialize(&field->link);
@@ -220 +216 @@
                         }
                         else {
-                                usage = report_item->usages[
+                                usage = report_item->usages[
                                         report_item->usages_count- 1]; 
                         }
@@ -245 +241 @@
 
                 field->size = report_item->size;
-
-                if(report_item->type == USB_HID_REPORT_TYPE_INPUT) {
-                        int offset = report_item->offset + report_item->size * i;
-                        int field_offset = (offset/8)*8 + (offset/8 + 1) * 8 - 
-                                offset - report_item->size;
-                        if(field_offset < 0) {
-                                field->offset = 0;
-                        }
-                        else {
-                                field->offset = field_offset;
-                        }
-                }
-                else {
-                        field->offset = report_item->offset + (i * report_item->size);
-                }
-
-
-                if(report->use_report_ids != 0) {
+                
+                size_t offset_byte = (report_item->offset + (i *
+                        report_item->size)) / 8; 
+
+                size_t offset_bit = 8 - ((report_item->offset + (i *
+                        report_item->size)) % 8) - report_item->size;
+
+                field->offset = 8 * offset_byte + offset_bit;
+                if(report_item->id != 0) {
                         field->offset += 8;
                         report->use_report_ids = 1;
                 }
-
                 field->item_flags = report_item->item_flags;
 

uspace/lib/usbhid/src/hidparser.c

@@ -153 +153 @@
 
 
-        report_des = usb_hid_report_find_description(report, *report_id, 
-                type);
-
+        report_des = usb_hid_report_find_description(report, *report_id, type);
         if(report_des == NULL) {
                 return EINVAL;
@@ -169 +167 @@
                 if(USB_HID_ITEM_FLAG_CONSTANT(item->item_flags) == 0) {
                         
-                        if(USB_HID_ITEM_FLAG_VARIABLE(item->item_flags) == 0){
+                        if(USB_HID_ITEM_FLAG_VARIABLE(item->item_flags) == 0) {
 
                                 // array
@@ -176 +174 @@
                 
                                 item->usage = USB_HID_EXTENDED_USAGE(
-                                    item->usages[
-                                    item->value - item->physical_minimum]);
-
-                                item->usage_page = 
-                                    USB_HID_EXTENDED_USAGE_PAGE(
-                                    item->usages[
-                                    item->value - item->physical_minimum]);
-
-                                usb_hid_report_set_last_item (
-                                    item->collection_path, 
-                                    USB_HID_TAG_CLASS_GLOBAL, 
-                                    item->usage_page);
-
-                                usb_hid_report_set_last_item (
-                                    item->collection_path, 
+                                    item->usages[item->value - item->physical_minimum]);
+
+                                item->usage_page = USB_HID_EXTENDED_USAGE_PAGE(
+                                    item->usages[item->value - item->physical_minimum]);
+
+                                usb_hid_report_set_last_item (item->collection_path, 
+                                    USB_HID_TAG_CLASS_GLOBAL, item->usage_page);
+
+                                usb_hid_report_set_last_item (item->collection_path, 
                                     USB_HID_TAG_CLASS_LOCAL, item->usage);
                                 
@@ -196 +188 @@
                         else {
                                 // variable item
-                                item->value = usb_hid_translate_data(item, 
-                                    data);                              
-                        }                       
+                                item->value = usb_hid_translate_data(item, data);                               
+                        }                               
                 }
                 list_item = list_item->next;
@@ -222 +213 @@
         
         int32_t value=0;
-        int32_t mask=0;
-        const uint8_t *foo=0;
+        int32_t mask;
+        const uint8_t *foo;
 
         // now only shot tags are allowed
@@ -249 +240 @@
         if((size_t)(offset/8) != (size_t)((offset+item->size-1)/8)) {
                 
-                part_size = 0;
+                part_size = ((offset+item->size)%8);
 
                 size_t i=0;
@@ -255 +246 @@
                         if(i == (size_t)(offset/8)) {
                                 // the higher one
-                                part_size = 8 - (offset % 8);
                                 foo = data + i;
                                 mask =  ((1 << (item->size-part_size))-1);
-                                value = (*foo & mask);
+                                value = (*foo & mask) << part_size;
                         }
                         else if(i == ((offset+item->size-1)/8)){
                                 // the lower one
                                 foo = data + i;
-                                mask = ((1 << (item->size - part_size)) - 1) 
-                                        << (8 - (item->size - part_size));
-
-                                value = (((*foo & mask) >> (8 - 
-                                    (item->size - part_size))) << part_size ) 
-                                    + value;
+                                mask =  ((1 << part_size)-1) << (8-part_size);
+                                value += ((*foo & mask) >> (8-part_size));
                         }
                         else {
-                                value = (*(data + 1) << (part_size + 8)) + value;
-                                part_size += 8;
+                                value = value << 8;
+                                value += *(data + 1);
                         }
                 }
@@ -389 +375 @@
                 report_item = list_get_instance(item, usb_hid_report_field_t, link);
 
-                value = usb_hid_translate_data_reverse(report_item, 
-                        report_item->value);
-
-                offset = report_des->bit_length - report_item->offset - 1;
-                length = report_item->size;
-                
+                if(USB_HID_ITEM_FLAG_VARIABLE(report_item->item_flags) == 0) {
+                                        
+                        // array
+                        value = usb_hid_translate_data_reverse(report_item, 
+                                report_item->value);
+
+                        offset = report_item->offset;
+                        length = report_item->size;
+                }
+                else {
+                        // variable item
+                        value  = usb_hid_translate_data_reverse(report_item, 
+                                report_item->value);
+
+                        offset = report_item->offset;
+                        length = report_item->size;
+                }
+
                 usb_log_debug("\ttranslated value: %x\n", value);
 
@@ -619 +617 @@
                         return report_des->report_id;
                 }
-
-                report_it = report_it->next;
         }